Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/kafkaexporter] Zipkin JSON encoding support #21102

Closed
yaroliakh opened this issue Apr 21, 2023 · 7 comments
Closed

[exporter/kafkaexporter] Zipkin JSON encoding support #21102

yaroliakh opened this issue Apr 21, 2023 · 7 comments
Assignees
@yaroliakh
Labels
enhancement New feature or request exporter/kafka good first issue Good for newcomers receiver/kafka

Comments

@yaroliakh
Copy link
Contributor

Component(s)

exporter/kafka

Is your feature request related to a problem? Please describe.

I would like Kafka exporter to have an option of sending traces in Zipkin JSON format.

Describe the solution you'd like

Following Kafka marshaler pattern adding Zipkin JSON encoding would be similar to existing Jager and OTLP_JSON encoders.

Describe alternatives you've considered

No response

Additional context

We'd like to start using Kafka for Zipkin trances and have this feature upstream. I can work on the implementation if this request finds positive feedback.
@yaroliakh yaroliakh added enhancement New feature or request needs triage New item requiring triage labels Apr 21, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Apr 24, 2023

You will need the kafka receiver to also support receiving zipkin traces.

@atoulme atoulme added receiver/kafka and removed needs triage New item requiring triage labels Apr 24, 2023
@github-actions
Copy link
Contributor

Pinging code owners for receiver/kafka: @pavolloffay @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@yaroliakh
Copy link
Contributor Author

You will need the kafka receiver to also support receiving zipkin traces.

In our particular case zipkin traces are received over HTTP, then exported to kafka and transformed by consumers into Zipkin. We'd like to avoid extra transformation outside OTel.

@MovieStoreGuy
Copy link
Contributor

I had thought this was done, but I happy to see it added.

@MovieStoreGuy MovieStoreGuy added the good first issue Good for newcomers label Apr 29, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 29, 2023
@yaroliakh yaroliakh mentioned this issue Jul 4, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
@crobert-1 crobert-1 reopened this Sep 8, 2023
codeboten pushed a commit that referenced this issue Oct 4, 2023
@yaroliakh
[exporter/kafkaexporter] add zipkin encoding for traces (#23947)
732d259 
**Description:** <Describe what has changed.>
Adding Zipkin v2 encoding support for traces in kafkaexporter 

**Link to tracking Issue:** <Issue number if applicable>

#21102

**Testing:** <Describe what testing was performed and which tests were
added.>
Test for `tracesMarshalers` has been extended with zipkin JSON test
case.
sumo-drosiek pushed a commit to sumo-drosiek/opentelemetry-collector-contrib that referenced this issue Oct 4, 2023
@yaroliakh @sumo-drosiek
[exporter/kafkaexporter] add zipkin encoding for traces (open-telemet…
d82c61e 
…ry#23947)

**Description:** <Describe what has changed.>
Adding Zipkin v2 encoding support for traces in kafkaexporter 

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#21102

**Testing:** <Describe what testing was performed and which tests were
added.>
Test for `tracesMarshalers` has been extended with zipkin JSON test
case.
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this issue Oct 9, 2023
@yaroliakh @jorgeancal
[exporter/kafkaexporter] add zipkin encoding for traces (open-telemet…
7ab4a01 
…ry#23947)

**Description:** <Describe what has changed.>
Adding Zipkin v2 encoding support for traces in kafkaexporter 

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#21102

**Testing:** <Describe what testing was performed and which tests were
added.>
Test for `tracesMarshalers` has been extended with zipkin JSON test
case.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@yaroliakh @jmsnll
[exporter/kafkaexporter] add zipkin encoding for traces (open-telemet…
16130e5 
…ry#23947)

**Description:** <Describe what has changed.>
Adding Zipkin v2 encoding support for traces in kafkaexporter 

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#21102

**Testing:** <Describe what testing was performed and which tests were
added.>
Test for `tracesMarshalers` has been extended with zipkin JSON test
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaroliakh yaroliakh

Labels
enhancement New feature or request exporter/kafka good first issue Good for newcomers receiver/kafka
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@atoulme @MovieStoreGuy @crobert-1 @yaroliakh