Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/resourcedetection] Add host.arch to system detector #22939

Closed
Tracked by #22045
mx-psi opened this issue May 30, 2023 · 0 comments · Fixed by #22940
Closed
Tracked by #22045

[processor/resourcedetection] Add host.arch to system detector #22939

mx-psi opened this issue May 30, 2023 · 0 comments · Fixed by #22940

Comments

@mx-psi
Copy link
Member

mx-psi commented May 30, 2023

No description provided.

This was referenced May 30, 2023
Closed
Merged
mx-psi added a commit that referenced this issue Jul 18, 2023
@mx-psi
[processor/resourcedetection] Add host.arch to system detector (#22940
02f688d 
)

**Description:** 

Add `host.arch` to system detector. It is detected via `runtime.GOARCH`.

This way of detecting may be wrong if running under an emulator or
binary translator; the only common case I know of this happening in
practice is on ARM64 macOS when using Rosetta. There is a way to detect
this (see DataDog/gohai/pull/77) but since we provide arm64 builds for
macOS, I think this is a non-issue

**Link to tracking Issue:** Fixes #22939

**Testing:** Added unit tests. Tested on my Linux AMD64 laptop

**Documentation:** Documented new attribute on README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mx-psi