Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component short names and types do not match #24171

Open
atoulme opened this issue Jul 10, 2023 · 6 comments
Open

Component short names and types do not match #24171

atoulme opened this issue Jul 10, 2023 · 6 comments
Labels
Stale

Comments

@atoulme
Copy link
Contributor

atoulme commented Jul 10, 2023

Component(s)

No response

Describe the issue you're reporting

As reported in #24045 (comment), we currently have 2 competing standards for the short names of components.

On one hand, we have the factory type used to register the component in distros.
On the other hand, we have a name derived off the folder name of the component - called short name for this issue.

Those names do not match and this is starting to impact the following elements:

  • The scope name is derived off the short name
  • The Github labels are derived off the short name

The type is used everywhere else, including in configuration.

The fix is to choose one option and stick to it moving forward, which may create breaking changes.
@atoulme atoulme mentioned this issue Jul 10, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Sep 11, 2023
@atoulme atoulme removed the Stale label Oct 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@atoulme atoulme removed the Stale label Feb 1, 2024
@atoulme atoulme mentioned this issue Feb 1, 2024
Merged
@dmitryax
Copy link
Member

I think it's ok to keep user configuration a bit different and allow _ for readability. but golang modules should not include them and always have exporter|processor|receiver|connector|extension suffix unless they are extension type defining interfaces like extension/storage

dmitryax pushed a commit that referenced this issue Feb 16, 2024
@atoulme
[extension/httpforwarder] rename httpforwarder to httpforwarderextens…
d903019 
…ion (#30981)

**Description:**
Deprecate the httpforwarder extension
Introduce the httpforwarderextension extension.

**Link to tracking Issue:**
Relates to #24171
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue Feb 19, 2024
@atoulme @djaglowski
[extension/httpforwarder] rename httpforwarder to httpforwarderextens…
226e096 
…ion (open-telemetry#30981)

**Description:**
Deprecate the httpforwarder extension
Introduce the httpforwarderextension extension.

**Link to tracking Issue:**
Relates to open-telemetry#24171
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue Feb 19, 2024
@atoulme @djaglowski
[extension/httpforwarder] rename httpforwarder to httpforwarderextens…
09c6e94 
…ion (open-telemetry#30981)

**Description:**
Deprecate the httpforwarder extension
Introduce the httpforwarderextension extension.

**Link to tracking Issue:**
Relates to open-telemetry#24171
@atoulme atoulme mentioned this issue Feb 29, 2024
Merged
dmitryax pushed a commit that referenced this issue Feb 29, 2024
@atoulme
[extension/httpforwarder] remove httpforwarder package (#31501)
2d1224c 
**Description:**
Remove extension named httpforwarder, use httpforwarderextension
instead.

**Link to tracking Issue:**
#24171
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
0218a4d 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
@kkujawa-sumo kkujawa-sumo mentioned this issue Mar 6, 2024
Merged
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
e8ac005 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 6, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
e9e81ae 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
5456880 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
3c397ac 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
- ConfigProvider is deprecated, use ConfigProviderSettings instead
  ref: open-telemetry/opentelemetry-collector#9228
kkujawa-sumo added a commit to SumoLogic/sumologic-otel-collector that referenced this issue Mar 7, 2024
@kkujawa-sumo
chore: update otelcol core to v0.96.0
a4f09fa 
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
- ConfigProvider is deprecated, use ConfigProviderSettings instead
  ref: open-telemetry/opentelemetry-collector#9228
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@atoulme @XinRanZhAWS
[extension/httpforwarder] rename httpforwarder to httpforwarderextens…
e30171d 
…ion (open-telemetry#30981)

**Description:**
Deprecate the httpforwarder extension
Introduce the httpforwarderextension extension.

**Link to tracking Issue:**
Relates to open-telemetry#24171
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@atoulme @XinRanZhAWS
[extension/httpforwarder] remove httpforwarder package (open-telemetr…
3cf1bd4 
…y#31501)

**Description:**
Remove extension named httpforwarder, use httpforwarderextension
instead.

**Link to tracking Issue:**
open-telemetry#24171
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 17, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Apr 17, 2024

This isn't blocking anything at the moment ; it's just a weird annoyance for a few components, especially receivercreator.

@github-actions github-actions bot removed the Stale label Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atoulme @dmitryax