Use Go 1.20 `errors.Join` instead of `go.uber.org/multierr` #25121

mx-psi · 2023-08-09T15:03:43Z

Component(s)

No response

Describe the issue you're reporting

Go 1.20 includes new builtin error joining support that can replace the usage of go.uber.org/multierr. We should switch to using these and ban the usage of go.uber.org/multierr via depguard (same as this).

Counterpart of open-telemetry/opentelemetry-collector#8210.

This is blocked by #25116

The text was updated successfully, but these errors were encountered:

bryan-aguilar · 2023-08-11T00:48:46Z

Would we prefer to see this per component or one big search and replace PR?

mx-psi · 2023-08-11T07:21:40Z

Would we prefer to see this per component or one big search and replace PR?

I guess it is up to whoever takes this, my experience is that per component (or at least not everything at once) is a bit less frustrating for contributors given the churn of conflicts

shivanshuraj1333 · 2023-08-11T08:01:05Z

I can work on this, @mx-psi kindly assign, would do once the blocker PR is merged.

…ultierr (#25183) Part of: #25121

) Related to #25121

Related to #25121

gord02 · 2023-08-30T17:08:09Z

Hello everyone. Are there any other components that need to migrate over to the new built-in error support?

mx-psi · 2023-08-31T08:17:48Z

Hey @gord02! There are still components that you can migrate, I think e.g. @shivanshu1333 has not gotten started with processors and most exporters are not done either.

Please see open-telemetry/opentelemetry-collector#8225 (comment) when making a PR: if replacing multierr.Append prefer appending to a slice and then using errors.Join on the slice!

bagmeg · 2023-10-14T07:52:29Z

Hi I'm interested in working on it. Can i work on it?

mx-psi · 2023-10-16T09:32:21Z

Sure, feel free to open a PR @bagmeg :)

…/multierr (#27835) **Description:** fileexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** #25121

….uber.org/multierr (#27857) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> #25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

…/multierr (open-telemetry#27835) **Description:** fileexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** open-telemetry#25121

….uber.org/multierr (open-telemetry#27857) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

…org/multierr (#27888) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> #25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

github-actions · 2024-02-12T03:30:43Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

**Link to tracking Issue:** - #25121

…org/multierr (#32509) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> #25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

acha1os · 2024-05-07T17:16:14Z

Hi I'm interested in helping with this, may I?

bryan-aguilar · 2024-05-07T17:22:15Z

Feel free to send PRs for components which are still using multierr to join errors.

…ierr (#32925) **Description:** syslogexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [#25121](#25121) **Testing:** **Documentation:**

…org/multierr (open-telemetry#32509) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

…ierr (open-telemetry#32925) **Description:** syslogexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [open-telemetry#25121](open-telemetry#25121) **Testing:** **Documentation:**

…rg/multierr (#32979) chronyreceiver: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [#25121](#25121)

…33052) **Description:** <Describe what has changed.> Replace multierr in favor of errors.Join **Link to tracking Issue:** #25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

github-actions · 2024-07-08T03:32:26Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

…org/multierr (open-telemetry#32509) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

…ierr (open-telemetry#32925) **Description:** syslogexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [open-telemetry#25121](open-telemetry#25121) **Testing:** **Documentation:**

…rg/multierr (open-telemetry#32979) chronyreceiver: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [open-telemetry#25121](open-telemetry#25121)

…pen-telemetry#33052) **Description:** <Describe what has changed.> Replace multierr in favor of errors.Join **Link to tracking Issue:** open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium ci-cd CI, CD, testing, build issues on hold This is blocked by another PR/issue labels Aug 9, 2023

mx-psi assigned shivanshuraj1333 Aug 11, 2023

This was referenced Aug 13, 2023

[chore] [clickhouseexporter] use errors.Join instead of go.uber.org/multierr #25183

Merged

[chore] migrate all the files under connector to use errors.Join #25184

Merged

dmitryax pushed a commit that referenced this issue Aug 14, 2023

[chore] [clickhouseexporter] use errors.Join instead of go.uber.org/m…

977eae4

…ultierr (#25183) Part of: #25121

dmitryax pushed a commit that referenced this issue Aug 14, 2023

[chore] migrate all the files under connector to use errors.Join (#25184

07db6e6

) Related to #25121

shivanshuraj1333 mentioned this issue Aug 14, 2023

[chore] Migrate all aws receviers to use errors.Join #25185

Merged

djaglowski pushed a commit that referenced this issue Aug 14, 2023

[chore] Migrate all aws receviers to use errors.Join (#25185)

e136bfd

Related to #25121

mx-psi removed the on hold This is blocked by another PR/issue label Aug 31, 2023

mx-psi assigned bagmeg Oct 16, 2023

bagmeg mentioned this issue Oct 18, 2023

[chore][exporter/fileexporter] use errors.Join instead of go.uber.org/multierr #27835

Merged

dmitryax pushed a commit that referenced this issue Oct 19, 2023

[chore][exporter/fileexporter] use errors.Join instead of go.uber.org…

be81ae7

…/multierr (#27835) **Description:** fileexporter: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** #25121

bagmeg mentioned this issue Oct 19, 2023

[chore][exporter/elasticsearchexporter] use errors.Join instead of go.uber.org/multierr #27857

Merged

bagmeg mentioned this issue Oct 20, 2023

[chore][exporter/datadogexporter] use errors.Join instead of go.uber.org/multierr #27888

Merged

bagmeg mentioned this issue Oct 23, 2023

[chore][exporter/opensearchexporter] use errors.Join instead of go.uber.org/multierr #27908

Merged

TylerHelmuth added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 13, 2023

TylerHelmuth mentioned this issue Dec 14, 2023

[chore] refactore carbonexporter to handle errors, use generic interfaces #29885

Merged

github-actions bot added the Stale label Feb 12, 2024

frzifus removed the Stale label Mar 14, 2024

led0nk mentioned this issue Mar 14, 2024

[internal/sqlquery] use errors.Join instead of multierr #31768

Merged

codeboten pushed a commit that referenced this issue Mar 15, 2024

[internal/sqlquery] use errors.Join instead of multierr (#31768)

3351c9d

**Link to tracking Issue:** - #25121

led0nk mentioned this issue Mar 15, 2024

[receiver/rabbitmqreceiver] use errors.Join instead of multierr #31779

Merged

dmitryax pushed a commit that referenced this issue Mar 15, 2024

[receiver/rabbitmqreceiver] use errors.Join instead of multierr (#31779)

d82d6f5

**Link to tracking Issue:** - #25121

bagmeg mentioned this issue Apr 18, 2024

[chore][receiver/datadogreceiver] use errors.Join instead of go.uber.org/multierr #32509

Merged

TylerHelmuth mentioned this issue May 3, 2024

[mdatagen] use mdatagen to produce component internal telemetry open-telemetry/opentelemetry-collector#10054

Merged

acha1os mentioned this issue May 7, 2024

[exporter/syslogexporter] use errors.Join instead of go.uber.org/multierr #32925

Merged

acha1os mentioned this issue May 10, 2024

[chore][receiver/chronyreceiver] use errors.Join instead of go.uber.org/multierr #32979

Merged

rogercoll mentioned this issue May 14, 2024

[receiver/elasticsearch] remove multierr from elasticsearch receiver #33052

Merged

codeboten pushed a commit that referenced this issue May 14, 2024

[chore][receiver/chronyreceiver] use errors.Join instead of go.uber.o…

3c608d0

…rg/multierr (#32979) chronyreceiver: use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** [#25121](#25121)

github-actions bot added the Stale label Jul 8, 2024

crobert-1 mentioned this issue Jul 10, 2024

32669 sumconnector config #33994

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Go 1.20 `errors.Join` instead of `go.uber.org/multierr` #25121

Use Go 1.20 `errors.Join` instead of `go.uber.org/multierr` #25121

mx-psi commented Aug 9, 2023 •

edited

Loading

bryan-aguilar commented Aug 11, 2023

mx-psi commented Aug 11, 2023

shivanshuraj1333 commented Aug 11, 2023 •

edited

Loading

gord02 commented Aug 30, 2023

mx-psi commented Aug 31, 2023

bagmeg commented Oct 14, 2023

mx-psi commented Oct 16, 2023

github-actions bot commented Feb 12, 2024

acha1os commented May 7, 2024

bryan-aguilar commented May 7, 2024

github-actions bot commented Jul 8, 2024

Use Go 1.20 errors.Join instead of go.uber.org/multierr #25121

Use Go 1.20 errors.Join instead of go.uber.org/multierr #25121

Comments

mx-psi commented Aug 9, 2023 • edited Loading

Component(s)

Describe the issue you're reporting

bryan-aguilar commented Aug 11, 2023

mx-psi commented Aug 11, 2023

shivanshuraj1333 commented Aug 11, 2023 • edited Loading

gord02 commented Aug 30, 2023

mx-psi commented Aug 31, 2023

bagmeg commented Oct 14, 2023

mx-psi commented Oct 16, 2023

github-actions bot commented Feb 12, 2024

acha1os commented May 7, 2024

bryan-aguilar commented May 7, 2024

github-actions bot commented Jul 8, 2024

Use Go 1.20 `errors.Join` instead of `go.uber.org/multierr` #25121

Use Go 1.20 `errors.Join` instead of `go.uber.org/multierr` #25121

mx-psi commented Aug 9, 2023 •

edited

Loading

shivanshuraj1333 commented Aug 11, 2023 •

edited

Loading