Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reciever/k8s_cluster] Remove redundant opencensus.resourcetype resource attribute #26487

Closed
dmitryax opened this issue Sep 6, 2023 · 3 comments
Closed

[reciever/k8s_cluster] Remove redundant opencensus.resourcetype resource attribute #26487

dmitryax opened this issue Sep 6, 2023 · 3 comments
Labels
on hold This is blocked by another PR/issue priority:p2 Medium receiver/k8scluster Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Sep 6, 2023 •
edited

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

This attribute doesn't bring any value. It was introduced as a side effect of using OpenCensus metrics model to collect the metrics.

Describe the solution you'd like

Given that the receiver is already migrated to pdata and doesn't use OC model anymore, we can remove the attribute. Ideally, it should be done through a deprecation process, which requires #19174 to be resolved first.
@dmitryax dmitryax added enhancement New feature or request needs triage New item requiring triage priority:p2 Medium receiver/k8scluster on hold This is blocked by another PR/issue and removed enhancement New feature or request needs triage New item requiring triage labels Sep 6, 2023
@github-actions github-actions bot mentioned this issue Sep 12, 2023
Open
This was referenced Sep 12, 2023
Open
Open
@povilasv
Copy link
Contributor

I can work on this, once mdatagen change lands

This was referenced Oct 10, 2023
Merged
Merged
dmitryax pushed a commit that referenced this issue Oct 11, 2023
@povilasv
[k8sclusterreceiver] remove opencensus.resourcetype resource attribute (
9dfa2f7 
#27616)

**Description:** 

This resource attribute was deprecated in prior release (
#27584)
so I am removing it.

**Link to tracking Issue:**

#26487
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this issue Oct 18, 2023
@povilasv @JaredTan95
[k8sclusterreceiver] remove opencensus.resourcetype resource attribute (
8276cc1 
open-telemetry#27616)

**Description:** 

This resource attribute was deprecated in prior release (
open-telemetry#27584)
so I am removing it.

**Link to tracking Issue:**

open-telemetry#26487
@povilasv povilasv mentioned this issue Oct 20, 2023
Closed
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@povilasv @jmsnll
[k8sclusterreceiver] remove opencensus.resourcetype resource attribute (
a3ebeef 
open-telemetry#27616)

**Description:** 

This resource attribute was deprecated in prior release (
open-telemetry#27584)
so I am removing it.

**Link to tracking Issue:**

open-telemetry#26487
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 20, 2023
@dmitryax
Copy link
Member Author

resolved by #27616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold This is blocked by another PR/issue priority:p2 Medium receiver/k8scluster Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitryax @povilasv