Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/translator/jaeger] Bump github.com/jaegertracing/jaeger from 1.41.0 to 1.49.0 broke tests #26567

Closed
songy23 opened this issue Sep 11, 2023 · 2 comments · Fixed by #28881
Closed
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file help wanted Extra attention is needed pkg/translator/jaeger

Comments

@songy23
Copy link
Member

songy23 commented Sep 11, 2023

Component(s)

pkg/translator/jaeger

What happened?

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6147608956/job/16679659646?pr=26563

go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
--- FAIL: TestProtoToTraces (0.01s)
    --- FAIL: TestProtoToTraces/two-spans-with-follower (0.00s)
        jaegerproto_to_traces_test.go:313: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces_test.go:313
            	Error:      	Not equal: 
            	            	expected: ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013440)}
            	            	actual  : ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013638)}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -70,3 +70,3 @@
            	            	         ParentSpanId: (data.SpanID) (len=8) {
            	            	-         00000000  00 00 00 00 00 00 00 00                           |........|
            	            	+         00000000  af ae ad ac ab aa a9 a8                           |........|
            	            	         },
            	Test:       	TestProtoToTraces/two-spans-with-follower
    --- FAIL: TestProtoToTraces/a-spans-with-two-parent (0.00s)
        jaegerproto_to_traces_test.go:313: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces_test.go:313
            	Error:      	Not equal: 
            	            	expected: ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013458)}
            	            	actual  : ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013878)}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -70,3 +70,3 @@
            	            	         ParentSpanId: (data.SpanID) (len=8) {
            	            	-         00000000  00 00 00 00 00 00 00 00                           |........|
            	            	+         00000000  af ae ad ac ab aa a9 a8                           |........|
            	            	         },
            	Test:       	TestProtoToTraces/a-spans-with-two-parent
FAIL

Collector version

mainline

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@songy23 songy23 added bug Something isn't working needs triage New item requiring triage labels Sep 11, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

  • pkg/translator/jaeger: @open-telemetry/collector-approvers @frzifus

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten
Copy link
Contributor

This was blocked by open-telemetry/opentelemetry-collector#8478

@codeboten codeboten added the dependencies Pull requests that update a dependency file label Nov 8, 2023
codeboten pushed a commit that referenced this issue Dec 8, 2023
Fixes #28647

After this is merged contributors can finally use go workspaces in this
repo.

Fixes #26567

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file help wanted Extra attention is needed pkg/translator/jaeger
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants