Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/opampextension] Subscribe to be notified of Collector's effective config #27293

Closed
Tracked by #16462
evan-bradley opened this issue Oct 2, 2023 · 0 comments · Fixed by #29277
Closed
Tracked by #16462

[extension/opampextension] Subscribe to be notified of Collector's effective config #27293

evan-bradley opened this issue Oct 2, 2023 · 0 comments · Fixed by #29277
Assignees
@evan-bradley
Labels
enhancement New feature or request extension/opamp

Comments

@evan-bradley
Copy link
Contributor

evan-bradley commented Oct 2, 2023 •
edited

Implement extension.NotifyConfig to be notified of the Collector's effective config and report it to the OpAMP server.
@evan-bradley evan-bradley mentioned this issue Oct 2, 2023
Closed
5 tasks
@evan-bradley evan-bradley changed the title Subscribe to be notified of Collector effective config [extension/opampextension] Subscribe to be notified of Collector effective config Oct 2, 2023
@evan-bradley evan-bradley mentioned this issue Oct 2, 2023
Merged
@evan-bradley evan-bradley changed the title [extension/opampextension] Subscribe to be notified of Collector effective config [extension/opampextension] Subscribe to be notified of Collector's effective config Oct 2, 2023
@crobert-1 crobert-1 added the enhancement New feature or request label Oct 2, 2023
This was referenced Oct 3, 2023
Closed
Open
portertech added a commit to sensu/opentelemetry-collector-contrib that referenced this issue Oct 3, 2023
@portertech
opamp agent extension, update todos to reference open-telemetry#27293
cd17ed1 
Signed-off-by: Sean Porter <portertech@gmail.com>
@JaredTan95 JaredTan95 mentioned this issue Nov 14, 2023
Closed
@haoqixu haoqixu mentioned this issue Nov 14, 2023
Merged
evan-bradley pushed a commit that referenced this issue Nov 30, 2023
@haoqixu @JaredTan95
[extension/opampextension] reports effective config (#29277)
16760c7 
**Link to tracking Issue:** resolve #27293

**Testing:**
unittest
manual test with opamp-go example:
* collector version: modified otelcontribcol including opampextension
* collector config: 
```yaml
receivers:
  # otlp:
  #   protocols:
  #     grpc:
  filelog:
    include:
      - /tmp/xxxxx.log

exporters:
  debug:
    #verbosity: debug

extensions:
  opamp:
    server:
      ws:
        endpoint: ws://127.0.0.1:4320/v1/opamp
        tls:
          insecure_skip_verify: true

service:
  pipelines:
    logs:
      receivers: [filelog]
      exporters: [debug]
  telemetry:
    logs:
      level: info
  extensions: [opamp]
```
* server ui: ![Screenshot 2023-11-28 at 22-14-59 OpAMP
Server](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/9400582/38ea49bb-f2f7-4618-859f-2b66257ef89a)

**Documentation:** README.md

---------

Co-authored-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-bradley evan-bradley

Labels
enhancement New feature or request extension/opamp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[extension/opampextension] reports effective config haoqixu/opentelemetry-collector-contrib
2 participants
@evan-bradley @crobert-1