Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/prometheus] Bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 broke tests #27398

Closed
songy23 opened this issue Oct 2, 2023 · 3 comments · Fixed by #27437
Closed

[exporter/prometheus] Bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 broke tests #27398

songy23 opened this issue Oct 2, 2023 · 3 comments · Fixed by #27437
Assignees
@dmitryax
Labels
bug Something isn't working exporter/prometheus

Comments

@songy23
Copy link
Member

songy23 commented Oct 2, 2023

Component(s)

exporter/prometheus

What happened?

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6384874206/job/17328633644?pr=27395

--- FAIL: TestCollectMetrics (0.01s)
    --- FAIL: TestCollectMetrics/IntGauge/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/IntGauge/WithTimestamp
    --- FAIL: TestCollectMetrics/IntGauge (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/IntGauge
    --- FAIL: TestCollectMetrics/Gauge/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/Gauge/WithTimestamp
    --- FAIL: TestCollectMetrics/Gauge (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/Gauge
    --- FAIL: TestCollectMetrics/IntSum/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/IntSum/WithTimestamp
    --- FAIL: TestCollectMetrics/IntSum (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/IntSum
    --- FAIL: TestCollectMetrics/Sum/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/Sum/WithTimestamp
    --- FAIL: TestCollectMetrics/Sum (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/Sum
    --- FAIL: TestCollectMetrics/MonotonicIntSum/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/MonotonicIntSum/WithTimestamp
    --- FAIL: TestCollectMetrics/MonotonicIntSum (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/MonotonicIntSum
    --- FAIL: TestCollectMetrics/MonotonicSum/WithTimestamp (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/MonotonicSum/WithTimestamp
    --- FAIL: TestCollectMetrics/MonotonicSum (0.00s)
        collector_test.go:452: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:452
            	Error:      	Expect "Desc{fqName: "test_space_test_metric", help: "test description", constLabels: {}, variableLabels: {label_1,label_2,job,instance}}" to match "variableLabels: \[.*label_1.+label_2.+job.+instance.*\]"
            	Test:       	TestCollectMetrics/MonotonicSum
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexporter	coverage: 97.1% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexporter	5.733s
FAIL

Collector version

mainline

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@songy23 songy23 added bug Something isn't working exporter/prometheus needs triage New item requiring triage labels Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Pinging code owners for exporter/prometheus: @Aneurysm9. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Oct 2, 2023
Closed
Closed
This was referenced Oct 3, 2023
Closed
Open
@songy23 songy23 mentioned this issue Oct 5, 2023
Merged
@songy23 songy23 removed the needs triage New item requiring triage label Oct 5, 2023
@songy23
Copy link
Member Author

songy23 commented Oct 5, 2023

Fixed in #27437

jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this issue Oct 9, 2023
@dmitryax @jorgeancal
[chore] Update collector core dependencies (open-telemetry#27437)
16bada0 
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt
to the metric description String() output change made the recent Prom
library version prometheus/client_golang#1296.

Fixes
open-telemetry#27398
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@dmitryax @jmsnll
[chore] Update collector core dependencies (open-telemetry#27437)
c254b68 
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt
to the metric description String() output change made the recent Prom
library version prometheus/client_golang#1296.

Fixes
open-telemetry#27398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryax dmitryax

Labels
bug Something isn't working exporter/prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Update collector core dependencies dmitryax/opentelemetry-collector-contrib
2 participants
@dmitryax @songy23