Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro should include owners #28628

Closed
codeboten opened this issue Oct 25, 2023 · 5 comments · Fixed by #29697
Closed

Distro should include owners #28628

codeboten opened this issue Oct 25, 2023 · 5 comments · Fixed by #29697
Assignees
Labels
chore cmd/mdatagen mdatagen command good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

Component(s)

cmd/mdatagen

Describe the issue you're reporting

There's a list of distros available in mdatagen:

var distros = map[string]string{
"core": "https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol",
"contrib": "https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib",
"aws": "https://github.com/aws-observability/aws-otel-collector",
"grafana": "https://github.com/grafana/agent",
"observiq": "https://github.com/observIQ/observiq-otel-collector",
"redhat": "https://github.com/os-observability/redhat-opentelemetry-collector",
"splunk": "https://github.com/signalfx/splunk-otel-collector",
"sumo": "https://github.com/SumoLogic/sumologic-otel-collector",
"liatrio": "https://github.com/liatrio/liatrio-otel-collector",
}

However, this list doesn't include any owners. This makes it difficult to review PRs that include adding a component to any particular distro. I propose that owners should be listed, much like code owners for each of the listed distro.

@codeboten codeboten added the needs triage New item requiring triage label Oct 25, 2023
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Oct 25, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Sounds good to me.

To complete this we'll also need to add automation to ping the distribution owners when necessary.

Do we want labels for each distribution as well? We can use that as the event to ping the relevant owners. Maybe something of the form distro:core, distro:contrib, etc.

@crobert-1 crobert-1 added chore and removed needs triage New item requiring triage labels Oct 31, 2023
@dmitryax
Copy link
Member

Do we want labels for each distribution as well? We can use that as the event to ping the relevant owners. Maybe something of the form distro:core, distro:contrib, etc.

Sounds like a good idea 👍

@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 31, 2023
@codeboten
Copy link
Contributor Author

I like the label idea... I don't know how often we would end up using it. The only changes I can think of that are distro specific are changes to readme files to include a component in a distro, which i don't know if it opens often enough to warrant automation.

@atoulme
Copy link
Contributor

atoulme commented Dec 7, 2023

I propose the following: we will create a file describing the contents of a distro generated via mdatagen, and have a CODEOWNERS entry generated from the owners of the distribution so we can tag anyone managing a specific distribution and make sure to notify them of any changes to their distribution.

@atoulme atoulme self-assigned this Dec 7, 2023
mx-psi pushed a commit that referenced this issue Dec 12, 2023
**Description:**
Adds a set of distribution reports that can be used to notify
distribution maintainers of any changes to distributions.

**Link to tracking Issue:**
Fixes #28628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore cmd/mdatagen mdatagen command good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants