Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testbed] Remove dependency on pkg/trace/exportable from mockdatadogexporter #29635

Closed
mx-psi opened this issue Dec 4, 2023 · 6 comments
Closed

[testbed] Remove dependency on pkg/trace/exportable from mockdatadogexporter #29635

mx-psi opened this issue Dec 4, 2023 · 6 comments
Labels
closed as inactive priority:p2 Medium Stale testbed/mockdatasenders/mockdatadogagentexporter testbed

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 4, 2023

Component(s)

No response

Describe the issue you're reporting

The mockdatadogagentexporter depends on pkg/trace/exportable. This module is a deprecated one-time module superseded by github.com/DataDog/datadog-agent/pkg/proto. It is not used anymore by any other Datadog-related module.

We should remove usage of it in favor of pkg/proto.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Pinging code owners for testbed: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Pinging code owners for testbed/mockdatasenders/mockdatadogagentexporter: @boostchicken. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Pinging code owners:

  • testbed: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi mx-psi mentioned this issue Dec 4, 2023
Merged
codeboten pushed a commit that referenced this issue Dec 4, 2023
@mx-psi
[renovate] Ignore github.com/DataDog/datadog-agent/pkg/trace/exportab…
80e54de 
…le updates (#29636)

**Description:** Ignores updates to
`github.com/DataDog/datadog-agent/pkg/trace/exportable` since:
- It is a deprecated module for which we won't make any updates
- It is causing trouble with renovatebot

**Link to tracking Issue:** Relates to #29635, should unblock #29411
@github-actions github-actions bot mentioned this issue Dec 5, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • testbed: @open-telemetry/collector-approvers
  • testbed/mockdatasenders/mockdatadogagentexporter: @boostchicken

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 5, 2024
@mx-psi mx-psi removed the Stale label Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • testbed: @open-telemetry/collector-approvers
  • testbed/mockdatasenders/mockdatadogagentexporter: @boostchicken

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed as inactive priority:p2 Medium Stale testbed/mockdatasenders/mockdatadogagentexporter testbed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mx-psi