New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: pkg/sampling #29738
Comments
I'm happy to sponsor this module |
I'd also like to sponsor. Go sampling! |
I would like to subscribe it as well. Probabilistic sampling policy is also available in tail-sampling processor. And I've seen discussion on Slack complaining it: #27044. So I have been looking forward to the probabilistic sampling being unified in SDKs, processors, and being managed in a unified manner. |
…29720) **Description:** This is the `pkg/sampling` portion of of #24811. **Link to tracking Issue:** #29738 open-telemetry/opentelemetry-specification#1413 **Testing:** Complete. **Documentation:** New README added. --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Kent Quirk <kentquirk@gmail.com>
…pen-telemetry#29720) **Description:** This is the `pkg/sampling` portion of of open-telemetry#24811. **Link to tracking Issue:** open-telemetry#29738 open-telemetry/opentelemetry-specification#1413 **Testing:** Complete. **Documentation:** New README added. --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Kent Quirk <kentquirk@gmail.com>
…pen-telemetry#29720) **Description:** This is the `pkg/sampling` portion of of open-telemetry#24811. **Link to tracking Issue:** open-telemetry#29738 open-telemetry/opentelemetry-specification#1413 **Testing:** Complete. **Documentation:** New README added. --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Kent Quirk <kentquirk@gmail.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This was done as part of #29720. |
The purpose and use-cases of the new component
New pkg/sampling component will contain common library code for:
Example configuration for the component
No direct configuration in yaml. This module supports a strictly defined translation between IEEE 754 floating point values and so-called "Threshold" values.
A simple component that uses this library (e.g., probabilisticsamplerprocessor) will extract probabilities from yaml configuration and convert them into a
Threshold
value using one of two methods:ProbabilityToThreshold
: exact translation from floating point to threshold, preserves all significant bits, in which case Threshold-to-Probability is an exact round trip.ProbabilityToThresholdWithPrecision
: approximate translation from floating point to threshold, will round probability value to limit the encoding size, in which case Threshold-to-Probability is not a round trip.Telemetry data types supported
Tracing receives direct support, in the sense that
Randomness
can be extracted frompcommon.TraceID
. However, theRandomness
type can be used directly and this package may be extended to apply consistent probability sampling to other data types.Is this a vendor-specific component?
Code Owner(s)
jmacd, kentquirk
Sponsor (optional)
codeboten
Additional context
This implements the draft specification proposal in open-telemetry/oteps#235
This implements the already-specified rules for tracestate handling: https://opentelemetry.io/docs/specs/otel/trace/tracestate-handling/
This is one step in an umbrella issue, the overall goal is stated here: open-telemetry/opentelemetry-specification#1413
The text was updated successfully, but these errors were encountered: