Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/githubgen] Report if members in allowlist are not associated with any components #30299

Closed
atoulme opened this issue Jan 4, 2024 · 0 comments · Fixed by #30300
Closed

[cmd/githubgen] Report if members in allowlist are not associated with any components #30299

atoulme opened this issue Jan 4, 2024 · 0 comments · Fixed by #30300
Labels
needs triage New item requiring triage

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 4, 2024

Component(s)

cmd/githubgen

Describe the issue you're reporting

Report as error if any member in allowlist are not used in any components. Follow up to #30296
@atoulme atoulme added the needs triage New item requiring triage label Jan 4, 2024
@atoulme atoulme mentioned this issue Jan 4, 2024
Merged
dmitryax pushed a commit that referenced this issue Jan 4, 2024
@atoulme
[chore] error out on codeowners in allowlist not used anywhere (#30300)
0bc65c2 
**Description:**
When running `make gengithub`, we now check if members of the allowlist
are not referenced anywhere.
```
$> make gengithub
cd cmd/githubgen && go install .
githubgen
2024/01/04 12:12:20 unused members in allowlist: , Doron-Bargo, keep94, oded-dd, thepeterstone
make: *** [gengithub] Error 1
```

**Link to tracking Issue:**
Fixes #30299

**Testing:**
Manual testing
@github-actions github-actions bot mentioned this issue Jan 9, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@atoulme @cparkins
[chore] error out on codeowners in allowlist not used anywhere (open-…
4e83c61 
…telemetry#30300)

**Description:**
When running `make gengithub`, we now check if members of the allowlist
are not referenced anywhere.
```
$> make gengithub
cd cmd/githubgen && go install .
githubgen
2024/01/04 12:12:20 unused members in allowlist: , Doron-Bargo, keep94, oded-dd, thepeterstone
make: *** [gengithub] Error 1
```

**Link to tracking Issue:**
Fixes open-telemetry#30299

**Testing:**
Manual testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
1 participant
@atoulme