Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/splunk_hec] Batch by resource attributes index and access token #30404

Closed
atoulme opened this issue Jan 10, 2024 · 2 comments · Fixed by #30407
Closed

[exporter/splunk_hec] Batch by resource attributes index and access token #30404

atoulme opened this issue Jan 10, 2024 · 2 comments · Fixed by #30407
Labels
enhancement New feature or request exporter/splunkhec

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 10, 2024

Component(s)

exporter/splunkhec

Is your feature request related to a problem? Please describe.

The Splunk HEC exporter gets a 400 error on sending batches if at least one element in the batch has a bad index value.

The fix is to batch per index, so we have a clean way to try batches without partial retries.

Describe the solution you'd like

Batch per index ; we already batch per access token, so batch by both.

Describe alternatives you've considered

No response

Additional context

No response
@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/splunkhec: @atoulme @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

This makes sense to me and was filed by a code owner, removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 10, 2024
@atoulme atoulme mentioned this issue Jan 10, 2024
Merged
dmitryax pushed a commit that referenced this issue Jan 10, 2024
@atoulme
[exporter/splunkhec] batch by index and access token (#30407)
8990edc 
**Description:**
Allow to batch with multiple keys. Use this new capability with the
Splunk HEC exporter.

**Link to tracking Issue:**
Fixes #30404
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@atoulme @cparkins
[exporter/splunkhec] batch by index and access token (open-telemetry#…
7fc5f5f 
…30407)

**Description:**
Allow to batch with multiple keys. Use this new capability with the
Splunk HEC exporter.

**Link to tracking Issue:**
Fixes open-telemetry#30404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/splunkhec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/splunkhec] batch by index and access token atoulme/opentelemetry-collector-contrib
2 participants
@atoulme @crobert-1