Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the relationship between cmd/opampsupervisor and extension/opampextension #30677

Closed
shenlvcheng opened this issue Jan 19, 2024 · 7 comments

Comments

@shenlvcheng
Copy link

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

What is the relationship between cmd/opampsupervisor and extension/opampextension

From what I understand, these two components work in conjunction. However, there's a question that confuses me: the configuration in opampsupervisor includes the setting for the OpAMP server address, and the opampextension also has a configuration for the server address. Why do both configurations specify the server address?"

@shenlvcheng shenlvcheng added the needs triage New item requiring triage label Jan 19, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added the question Further information is requested label Jan 19, 2024
@zzadxz
Copy link

zzadxz commented Jan 20, 2024

Hey @shenlvcheng!
This is because each component is designed to operate independently in different environments. Since they shouldn't rely on a shared configuration, they both need to know the server address individually. They both interact with the same server but they do it in different ways and for different purposes. Let's say the supervisor might not be configuring or managing server parameters but the extension might be using services provided by the server. Hope that answers your question!

@shenlvcheng
Copy link
Author

Hey @zzadxz !
If we consider each component separately, your explanation is fine. However, it doesn't address my question. After reviewing the relevant specifications and documentation, it's clear that these two components are supposed to interact with each other. But here's the issue: both components are WebSocket clients. In the opampsupervisor specification, there's a mention of a server, but I can't find the configuration for it anywhere. Can you tell me how to configure the server in opampsupervisor?

@srikanthccv
Copy link
Member

In the opampsupervisor specification, there's a mention of a server, but I can't find the configuration for it anywhere. Can you tell me how to configure the server in opampsupervisor?

The configurable settings for the OpAMP server are here https://github.com/open-telemetry/opamp-go/blob/fcfa0954c545e1b842a3d64adada28d0c032a518/server/server.go#L12-L36

@tigrannajaryan
Copy link
Member

There are 2 ways to use OpAMP with the Collector.

  1. You can use opampextension just on its own, without the opampsupervisor. In that case opampextension connects directly to the OpAMP server and needs to know the server's location.

  2. You can also use opampextension together with opampsupervisor. In this case opampextension is a helper for opampsupervisor. opampextension connects to locally running opampsupervisor and opampsupervisor connects to the actual OpAMP server running somewhere else, that's why opampsupervisor needs to know the server's address. In this scenario the opampserver's server setting points to the supervisor, not to the final server. See the design here https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/opampsupervisor/specification#supervised-operation

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 23, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 25, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants