Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to make Docker API Version default to 1.24+ #30900

Closed
samiura opened this issue Jan 31, 2024 · 3 comments · Fixed by #30927
Closed

Need to make Docker API Version default to 1.24+ #30900

samiura opened this issue Jan 31, 2024 · 3 comments · Fixed by #30927
Assignees
@samiura
Labels
extension/observer/dockerobserver

Comments

@samiura
Copy link
Contributor

samiura commented Jan 31, 2024 •
edited

Component(s)

No response

Describe the issue you're reporting

Currently, the Docker Observer's client API version is set to 1.22 as default. But due to this change on Docker upstream project, we need to make the Client API version default to 1.24. Most of the other projects except Otel have already updated. Also this impending PR once merged will cause problems like the following error message below. Right now, if someone uses the latest Docker API version 1.44, otel collector's docker observer will throw the following error:

_"Error response from daemon: client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version"_
@samiura samiura added the needs triage New item requiring triage label Jan 31, 2024
@atoulme atoulme added extension/observer/dockerobserver and removed needs triage New item requiring triage labels Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for extension/observer/dockerobserver: @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@samiura
Copy link
Contributor Author

samiura commented Jan 31, 2024

@atoulme thanks for adding the labels.

@atoulme atoulme mentioned this issue Jan 31, 2024
Merged
@jamesmoessis
Copy link
Contributor

As a rule of thumb we are just trying to keep the API at minimum version as possible. Seems like this change in docker means that the minimum becomes 1.24, so I think we should do it. Would need dockerstatsreceiver changes too.

dmitryax pushed a commit that referenced this issue Feb 1, 2024
@samiura
[extension/observer] Change default Docker client API version from 1.…
7e1e965 
…22 to 1.24 (#30927)

**Description:** Docker Client API default has been upgraded from 1.22
to 1.24. The details of the requirements to this change has been given
in the accompanying issue with docker upstream PRs.
**Link to tracking Issue:** 
Fixes #30900
**Testing:** Updated unit tests accordingly and ran integration tests to
make sure everything works as it should.
@github-actions github-actions bot mentioned this issue Feb 6, 2024
Closed
@bruegth bruegth mentioned this issue Feb 8, 2024
Open
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this issue Feb 12, 2024
@samiura @anthoai97
[extension/observer] Change default Docker client API version from 1.…
19819c1 
…22 to 1.24 (open-telemetry#30927)

**Description:** Docker Client API default has been upgraded from 1.22
to 1.24. The details of the requirements to this change has been given
in the accompanying issue with docker upstream PRs.
**Link to tracking Issue:** 
Fixes open-telemetry#30900
**Testing:** Updated unit tests accordingly and ran integration tests to
make sure everything works as it should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samiura samiura

Labels
extension/observer/dockerobserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default Docker client API version from 1.22 to 1.24 samiura/opentelemetry-collector-contrib
3 participants
@atoulme @jamesmoessis @samiura