Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: Google Client Auth Extension #31412

Closed
2 tasks done
damemi opened this issue Feb 26, 2024 · 6 comments
Closed
2 tasks done

New component: Google Client Auth Extension #31412

damemi opened this issue Feb 26, 2024 · 6 comments
Labels
Accepted Component New component has been sponsored Stale

Comments

@damemi
Copy link
Contributor

damemi commented Feb 26, 2024

The purpose and use-cases of the new component

Google Client Auth Extension provides Google OAuth2 Client Credentials and Metadata for gRPC and http based exporters. It allows exporters to authenticate with GCP and send telemetry to endpoints in Google Cloud.

Example configuration for the component

extensions:
  googleclientauth:
    project: my-project
    quota_project: billing-project
    scopes:
    - "https://www.googleapis.com/auth/cloud-platform"

receivers:
  otlp:
    protocols:
      grpc:

exporters:
  otlp/withauth:
    endpoint: 0.0.0.0:5000
    ca_file: /tmp/certs/ca.pem
    auth:
      authenticator: googleclientauth

service:
  extensions: [googleclientauth]
  pipelines:
    metrics:
      receivers: [otlp]
      processors: []
      exporters: [otlp/withauth]

Telemetry data types supported

traces, metrics, logs

Is this a vendor-specific component?

  • This is a vendor-specific component
  • If this is a vendor-specific component, I am proposing to contribute and support it as a representative of the vendor.

Code Owner(s)

dashpole, damemi

Sponsor (optional)

dashpole

Additional context

Component is currently available downstream at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/87124ac8635698cc7cdc9f8f2dfca94a8aa13606/extension/googleclientauthextension

@damemi damemi added needs triage New item requiring triage Sponsor Needed New component seeking sponsor labels Feb 26, 2024
@damemi
Copy link
Contributor Author

damemi commented Feb 26, 2024

cc @dashpole

@dashpole
Copy link
Contributor

I will sponsor the component. To answer the obvious question:

How is this different from the oauth2 client auth extension?

@damemi
Copy link
Contributor Author

damemi commented Feb 29, 2024

First PR opened at #31518 to just add the scaffolding

djaglowski pushed a commit that referenced this issue Mar 26, 2024
#31518)

**Description:**
This adds the basic component boilerplate following the recommendations
for PR1 in
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

**Link to tracking Issue:**
#31412

**Testing:** Ran various `make ...` commands as listed in docs. Ignored
generated files and failures from unrelated components.

**Documentation:** New readme and metadata (to be filled in, see
tracking issue)

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 30, 2024
@dashpole
Copy link
Contributor

@damemi can this be closed?

@damemi
Copy link
Contributor Author

damemi commented Apr 30, 2024

@damemi can this be closed?

Yup, thanks!

@damemi damemi closed this as completed Apr 30, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
open-telemetry#31518)

**Description:**
This adds the basic component boilerplate following the recommendations
for PR1 in
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

**Link to tracking Issue:**
open-telemetry#31412

**Testing:** Ran various `make ...` commands as listed in docs. Ignored
generated files and failures from unrelated components.

**Documentation:** New readme and metadata (to be filled in, see
tracking issue)

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored Stale
Projects
None yet
Development

No branches or pull requests

3 participants