Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] changelog workflow fails due to a bug in latest markdown-link-check #31680

Closed
andrzej-stencel opened this issue Mar 11, 2024 · 0 comments · Fixed by #31681
Closed

[ci] changelog workflow fails due to a bug in latest markdown-link-check #31680

andrzej-stencel opened this issue Mar 11, 2024 · 0 comments · Fixed by #31681
Assignees
Labels
ci-cd CI, CD, testing, build issues

Comments

@andrzej-stencel
Copy link
Member

Component(s)

No response

Describe the issue you're reporting

The markdown-link-check release v3.12.0 (published on Sunday 2024-03-10 around 18:06 UTC) contains a bug that causes it to fail if the --ignore flag is not passed.

Example: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8228894538/job/22505249862

Run markdown-link-check \
  markdown-link-check \
    --verbose \
    --config .github/workflows/check_links_config.json \
    changelog_preview.md \
    || { echo "Check that anchor links are lowercase"; exit 1; }
  shell: /usr/bin/bash -e {0}
  env:
    SEGMENT_DOWNLOAD_TIMEOUT_MINS: 2
    PR_HEAD: 2f898337653a4b34a2b985142eec5b247dee93a5
/usr/local/lib/node_modules/markdown-link-check/markdown-link-check:97
                    if (program.opts().ignore.some((ignorePath) => resolved.includes(ignorePath))) {
                                             ^
TypeError: Cannot read properties of undefined (reading 'some')
    at Command.<anonymous> (/usr/local/lib/node_modules/markdown-link-check/markdown-link-check:97:46)
    at Command.listener [as _actionHandler] (/usr/local/lib/node_modules/markdown-link-check/node_modules/commander/lib/command.js:482:17)
    at /usr/local/lib/node_modules/markdown-link-check/node_modules/commander/lib/command.js:1283:65
    at Command._chainOrCall (/usr/local/lib/node_modules/markdown-link-check/node_modules/commander/lib/command.js:1177:12)
    at Command._parseCommand (/usr/local/lib/node_modules/markdown-link-check/node_modules/commander/lib/command.js:1283:27)
    at Command.parse (/usr/local/lib/node_modules/markdown-link-check/node_modules/commander/lib/command.js:909:10)
    at getInputs (/usr/local/lib/node_modules/markdown-link-check/markdown-link-check:108:7)
    at main (/usr/local/lib/node_modules/markdown-link-check/markdown-link-check:252:20)
Node.js v18.19.1
Check that anchor links are lowercase
Error: Process completed with exit code 1.
@andrzej-stencel andrzej-stencel added the needs triage New item requiring triage label Mar 11, 2024
@andrzej-stencel andrzej-stencel self-assigned this Mar 11, 2024
@andrzej-stencel andrzej-stencel added ci-cd CI, CD, testing, build issues and removed needs triage New item requiring triage labels Mar 11, 2024
andrzej-stencel added a commit to andrzej-stencel/opentelemetry-collector-contrib that referenced this issue Mar 11, 2024
Fixes open-telemetry#31680

Let's pin markdown-link-check to the previous version v3.11.2 until the bug in the latest version v3.12.0 is fixed.
mx-psi pushed a commit that referenced this issue Mar 11, 2024
Fixes #31680

Let's pin markdown-link-check to the previous version v3.11.2 until the
bug in the latest version v3.12.0 is fixed.
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
Fixes open-telemetry#31680

Let's pin markdown-link-check to the previous version v3.11.2 until the
bug in the latest version v3.12.0 is fixed.
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
Fixes open-telemetry#31680

Let's pin markdown-link-check to the previous version v3.11.2 until the
bug in the latest version v3.12.0 is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant