Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Use batch sender exporter helper for reliability #32377

Open
carsonip opened this issue Apr 15, 2024 · 4 comments · May be fixed by #32632
Open

[exporter/elasticsearch] Use batch sender exporter helper for reliability #32377

carsonip opened this issue Apr 15, 2024 · 4 comments · May be fixed by #32632
Labels

Comments

@carsonip
Copy link
Contributor

carsonip commented Apr 15, 2024

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

This is a way to fix the issue reported in #30792.

In case of a collector crash, the events buffered within the bulk indexer in memory will be lost, even with a persistent queue.

Describe the solution you'd like

Move the buffering from bulk indexer to exporterhelper batch sender introduced in open-telemetry/opentelemetry-collector#8122, such that events are deleted from the queue only when they are flushed by bulk indexer.

Describe alternatives you've considered

No response

Additional context

I'm already working on a draft and related PRs are on their way.

exporterhelper batch sender open-telemetry/opentelemetry-collector#8122 is WIP and interface may change. Some features (e.g. batching by bytes) may not be available yet.

Blockers

@carsonip carsonip added enhancement New feature or request needs triage New item requiring triage labels Apr 15, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

This enhancement makes sense to me, and sounds like a good idea. I'll defer to code owners in case there are component-specific thoughts here.

Removing needs triage.

@ycombinator
Copy link
Contributor

This enhancement makes sense to me, and sounds like a good idea. I'll defer to code owners in case there are component-specific thoughts here.

Agreed, +1

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added Stale and removed Stale labels Jul 8, 2024
mx-psi pushed a commit that referenced this issue Jul 22, 2024
…batch sender (#34127)

**Description:**

Refactor the Elasticsearch bulk indexer code to create an abstraction
around the existing buffering, asynchronous bulk indexer.

This is preparation for supporting two implementations of bulk indexing:
the existing asynchronous one, and a new synchronous one that works well
with exporterhelper's batch sender -- see
#32632.

**Link to tracking Issue:**


#32377

**Testing:**

N/A, this is a non-functional change.

**Documentation:**

N/A, pure refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants