Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include service.version in prom to otlp #32398

Closed
jaronoff97 opened this issue Apr 15, 2024 · 6 comments
Closed

Include service.version in prom to otlp #32398

jaronoff97 opened this issue Apr 15, 2024 · 6 comments
Assignees
Labels

Comments

@jaronoff97
Copy link
Contributor

Component(s)

receiver/prometheus

Is your feature request related to a problem? Please describe.

Right now service.name, service.instance.id, and a few others are converted to OTLP semantic convention. service.version is currently not converted.

Describe the solution you'd like

I think it would be great if the value for service_version were converted with similar logic to allow for compatibility with otel recommendations.

Describe alternatives you've considered

I've considered using a transform processor, which would make this work, but I don't think it would let me move something from the attribute to the

Additional context

No response

@jaronoff97 jaronoff97 added enhancement New feature or request needs triage New item requiring triage labels Apr 15, 2024
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Apr 15, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jaronoff97
Copy link
Contributor Author

Actually, shouldn't this be set on all my telemetry from here?

@dashpole
Copy link
Contributor

Not sure I understand. The prometheus receiver converts from Prometheus' job and instance to service.name and service.instance.id. It will take all attributes of the target_info metric, if present, and convert it to other resource attributes. However, until Prometheus has UTF-8 support, the attributes will have underscores (e.g. service_version).

@dashpole dashpole removed the needs triage New item requiring triage label Apr 16, 2024
@dashpole dashpole self-assigned this Apr 16, 2024
@jaronoff97
Copy link
Contributor Author

sorry – i mean right now we get in service_version as a prometheus label for the collector's own metrics (and other services potentially using the prometheus metrics exporter in the otel SDKs). I'm suggesting that we do a similar conversion for service_version as we currently do for otel_scope_version so that we can set the resource attribute's service.version so that it's propagated.

You're probably right that until prometheus has that support this may add too much complexity.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 17, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants