Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding Extensions not in Contrib Distribution #32723

Open
blakeromano opened this issue Apr 26, 2024 · 8 comments
Open

Encoding Extensions not in Contrib Distribution #32723

blakeromano opened this issue Apr 26, 2024 · 8 comments

Comments

@blakeromano
Copy link
Contributor

Component(s)

extension/encoding, extension/encoding/jsonlogencoding

Describe the issue you're reporting

When trying to use the encoding extension on contrib distribution I got the error saying this extension was not in the contrib provider using otel/opentelemetry-collector-contrib:0.99.0 image.

Encoders are going to be important for having more encoding options for various other components.

Copy link
Contributor

Pinging code owners:

%s See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Removing needs triage based on code owner's response, and since there are a number of PRs currently open moving encoding extensions to be Alpha stability.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 26, 2024
MovieStoreGuy pushed a commit that referenced this issue Apr 29, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
I noticed the output of a recent comment made by the `github-actions`
bot had an extra `%s` in its output when pinging code owners on new
issues. This is unnecessary.

Example links:

#32666 (comment)

#32723 (comment)
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…elemetry#32724)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
I noticed the output of a recent comment made by the `github-actions`
bot had an extra `%s` in its output when pinging code owners on new
issues. This is unnecessary.

Example links:

open-telemetry#32666 (comment)

open-telemetry#32723 (comment)
@blakeromano
Copy link
Contributor Author

@crobert-1 With the recent release promoting to Alpha does that mean the contrib distribution will now have the encoding extensions or does this require additional work?

@crobert-1
Copy link
Member

crobert-1 commented May 13, 2024

It looks like some encoding extensions are currently included in releases: Jaegar, OTLP, and Zipkin.

From here.

Is there another you want to be released? (I see you mentioned the JSON log encoding extension)

@blakeromano
Copy link
Contributor Author

Correct the JSON log encoding extension is the big one I am looking at. I am happy to PR that repo if that is the best way to go about it.

@crobert-1
Copy link
Member

@VihasMakwana @atoulme Do you think the JSON log encoding extension is ready to be upgraded to alpha? If not, what remaining work is necessary?

@blakeromano
Copy link
Contributor Author

Any updates on this?

@crobert-1
Copy link
Member

It's been upgraded to alpha, but hasn't been added to collector releases yet. I've opened open-telemetry/opentelemetry-collector-releases#558 to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants