Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] vcenter.vm.disk.throughput Not Implemented #32772

Closed
StefanKurek opened this issue Apr 30, 2024 · 3 comments
Closed

[receiver/vcenter] vcenter.vm.disk.throughput Not Implemented #32772

StefanKurek opened this issue Apr 30, 2024 · 3 comments
Labels
bug Something isn't working receiver/vcenter

Comments

@StefanKurek
Copy link
Contributor

Component(s)

receiver/vcenter

What happened?

Description

I can see in the code that this metric was not actually implemented.

Steps to Reproduce

Collect against any vCenter environment with VMs.

Expected Result

vcenter.vm.disk.throughput is returned for each VM.

Actual Result

No vcenter.vm.disk.throughput metric is returned.

Collector version

v1.6.0/v0.99.0

Environment information

No response

OpenTelemetry Collector configuration

extensions:
  basicauth/prom:
    client_auth:
      username: [PROMUSER]
      password: [PROMPASS]

exporters:
  prometheusremotewrite:
    endpoint: [PROMENDPOINT]
    auth:
      authenticator: basicauth/prom
    resource_to_telemetry_conversion:
      enabled: true # Convert resource attributes to metric labels

processors:
  batch:
    # https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor

receivers:
  vcenter:
    endpoint: https://[VCENTERHOST]
    username: [VCENTERUSER]
    password: [VCENTERPASS]
    tls:
      insecure: true
    collection_interval: 1m
    initial_delay: 1s

service:
  extensions: [basicauth/prom]
  pipelines:
    metrics:
      receivers: [vcenter]
      processors: [batch]
      exporters: [prometheusremotewrite]

Log output

No response

Additional context

No response

@StefanKurek StefanKurek added bug Something isn't working needs triage New item requiring triage labels Apr 30, 2024
@StefanKurek
Copy link
Contributor Author

@djaglowski I propose implementing this metric, closely matching the currently implemented vcenter.host.disk.throughput metric. I would change the current metadata so that it is a gauge instead of a non-monotonic cumulative sum though (this is more correct as it is reported as a KB/s rate calculated over 20s).

Copy link
Contributor

Pinging code owners for receiver/vcenter: @djaglowski @schmikei @StefanKurek. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label May 1, 2024
djaglowski pushed a commit that referenced this issue May 1, 2024
**Description:** <Describe what has changed.>
Adds missing functionality for `vcenter.vm.disk.throughput` metric on VM
resources.
Also changes the metric from a Sum to a Gauge.

**Link to tracking Issue:** <Issue number if applicable>
#32772 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
@djaglowski
Copy link
Member

Closed by #32780

rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…lemetry#32780)

**Description:** <Describe what has changed.>
Adds missing functionality for `vcenter.vm.disk.throughput` metric on VM
resources.
Also changes the metric from a Sum to a Gauge.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32772 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this issue May 14, 2024
…lemetry#32780)

**Description:** <Describe what has changed.>
Adds missing functionality for `vcenter.vm.disk.throughput` metric on VM
resources.
Also changes the metric from a Sum to a Gauge.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32772 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/vcenter
Projects
None yet
Development

No branches or pull requests

4 participants