Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension/sumologic: lint failure with latest linter #33494

Closed
codeboten opened this issue Jun 11, 2024 · 1 comment · Fixed by #34083
Closed

extension/sumologic: lint failure with latest linter #33494

codeboten opened this issue Jun 11, 2024 · 1 comment · Fixed by #34083
Labels
extension/sumologic

Comments

@codeboten
Copy link
Contributor

Component(s)

extension/sumologic

Describe the issue you're reporting

The latest linter update causes this failure in the extesion:

INFO [runner] linters took 4.040160334s with stages: goanalysis_metalinter: 4.03714625s 
sumologicextension/extension.go:490:76: (*SumologicExtension).handleRegistrationError - result 0 (github.com/open-telemetry/opentelemetry-collector-contrib/extension/sumologicextension/credentials.CollectorCredentials) is always nil (unparam)

See #33477
@codeboten codeboten added the needs triage New item requiring triage label Jun 11, 2024
codeboten added a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Jun 11, 2024
@codeboten
[chore] unblock golangci-lint update
054a06c 
Skip linting, added a separate issue to track updating the code open-telemetry#33494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Jun 11, 2024
@codeboten
[chore] unblock golangci-lint update
d433f01 
Skip linting, added a separate issue to track updating the code open-telemetry#33494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten mentioned this issue Jun 11, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

codeboten added a commit that referenced this issue Jun 11, 2024
@codeboten
[chore] unblock golangci-lint update (#33495)
43aee3b 
Skip linting, added a separate issue to track updating the code
#33494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
t00mas pushed a commit to t00mas/opentelemetry-collector-contrib that referenced this issue Jun 18, 2024
@codeboten @t00mas
[chore] unblock golangci-lint update (open-telemetry#33495)
de9e9ea 
Skip linting, added a separate issue to track updating the code
open-telemetry#33494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot mentioned this issue Jul 2, 2024
Open
@github-actions github-actions bot mentioned this issue Jul 9, 2024
Open
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@codeboten @cparkins
[chore] unblock golangci-lint update (open-telemetry#33495)
83c4d30 
Skip linting, added a separate issue to track updating the code
open-telemetry#33494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@crobert-1 crobert-1 mentioned this issue Jul 15, 2024
Merged
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jul 15, 2024
codeboten pushed a commit that referenced this issue Jul 17, 2024
@crobert-1
[chore][extension/sumologic] Fix lint error (#34083)
f997202 
The `handleRegistrationError` method was always returning `nil` for the
`credentials.CollectorCredentials` argument. This was causing lint
failures. I've updated the method signature for this and the single
method calling it.

I don't believe a changelog entry is required as this is not a
functional change, and only impacts a private member method.

Fixes
#33494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension/sumologic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][extension/sumologic] Fix lint error crobert-1/opentelemetry-collector-contrib
2 participants
@codeboten @crobert-1