Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review public API for tanzuobservabilityexporter #4057

Closed
Tracked by #4055
mx-psi opened this issue Jul 1, 2021 · 1 comment
Closed
Tracked by #4055

Review public API for tanzuobservabilityexporter #4057

mx-psi opened this issue Jul 1, 2021 · 1 comment
Assignees
@oppegard

Comments

@mx-psi
Copy link
Member

mx-psi commented Jul 1, 2021 •
edited

cc @oppegard @thepeterstone see the parent issue for context. Can I assign this to either of you?

I think you can make some things private e.g. this

opentelemetry-collector-contrib/exporter/tanzuobservabilityexporter/transformer.go

Line 47 in fba0e93

type Span struct {

@mx-psi mx-psi mentioned this issue Jul 1, 2021
Closed
71 tasks
@oppegard
Copy link
Member

oppegard commented Jul 1, 2021

@mx-psi you can assign this to me.

@github-actions github-actions bot added the Stale label Jul 21, 2021
oppegard added a commit to thepeterstone/opentelemetry-collector-contrib that referenced this issue Jul 22, 2021
@oppegard
[exporter/tanzuobservability] Unexport private funcs and types
83b3599 
Resolves open-telemetry#4057
@oppegard oppegard mentioned this issue Jul 22, 2021
Merged
oppegard added a commit to thepeterstone/opentelemetry-collector-contrib that referenced this issue Jul 23, 2021
@oppegard
[exporter/tanzuobservability] Unexport private funcs and types
285f163 
Resolves open-telemetry#4057
@bogdandrutu bogdandrutu reopened this Aug 9, 2021
@bogdandrutu bogdandrutu removed the Stale label Aug 9, 2021
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this issue Aug 31, 2021
@oppegard
[exporter/tanzuobservability] Unexport private funcs and types (open-…
3c328c5 
…telemetry#4306)

Resolves open-telemetry#4057
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this issue Jun 2, 2022
@MovieStoreGuy
Improving usability of combined errors throughout the collector (open…
f26106c 
…-telemetry#4057)

* Making a change to allow for combined errors to support go 1.13+ error
handling

The idea behind this means that there is no need to discard errors in
order to combine them. This approach allows for the original errors to
be intact while only returning a singular error.

* Simplifying the iterate function

* Further simplification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oppegard oppegard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oppegard @bogdandrutu @mx-psi