Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Receiver ] Modify existing test to validate core metric types #6000

Closed
PaurushGarg opened this issue Oct 30, 2021 · 2 comments
Closed
Labels
ci-cd CI, CD, testing, build issues comp:prometheus Prometheus related issues comp: receiver Receiver Stale

Comments

@PaurushGarg
Copy link
Member

PaurushGarg commented Oct 30, 2021

Is your feature request related to a problem? Please describe.
Problem Statement:
The existing test checks for core metric types (gauge, counter, histogram, and summary) and their values. The validation part of this test is skipped because this test has been failing due to insertion of staleness markers.
See:

Current Behavior
The current behavior shows that if the validation is re-enabled the tests fail at the AssertUp due to failed scrapes, as the test falsely assume that staleness markers will not be returned. The functionality to make this test work after inclusion of staleness markers needs to be added.

Describe the solution you'd like
We propose the following solution

Modify the existing test to add a method to filter out the failed scrapes in the function getValidScrapes :

func getValidScrapes(t *testing.T, mds []*agentmetricspb.ExportMetricsServiceRequest) []*agentmetricspb.ExportMetricsServiceRequest {

Result Expected: Once this filter is added, all Prometheus metric types will be validated.

We’d like to get feedback on alternative solutions so please comment on this issue.

Additional context
Related to: open-telemetry/wg-prometheus#57
cc: @alolita @Aneurysm9

@PaurushGarg PaurushGarg changed the title Modify existing test to validate default metric types for Prometheus Receiver Modify existing test to validate default metric types for the Prometheus Receiver Nov 1, 2021
@alolita alolita added comp:prometheus Prometheus related issues ci-cd CI, CD, testing, build issues comp: receiver Receiver labels Nov 2, 2021
@PaurushGarg
Copy link
Member Author

@alolita please assign this issue to me. I would like to work on this one.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
* SIGHUP configuration reload

Signed-off-by: Sean Porter <portertech@gmail.com>

* basic SIGHUP reload signal test

Signed-off-by: Sean Porter <portertech@gmail.com>

* always notify with SIGHUP for configuration reloading

Signed-off-by: Sean Porter <portertech@gmail.com>

* sighup reload changelog entry

Signed-off-by: Sean Porter <portertech@gmail.com>

Signed-off-by: Sean Porter <portertech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues comp:prometheus Prometheus related issues comp: receiver Receiver Stale
Projects
None yet
Development

No branches or pull requests

3 participants