Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Receiver] Added testcase for core Prometheus metrics #6681

Conversation

PaurushGarg
Copy link
Member

@PaurushGarg PaurushGarg commented Dec 9, 2021

Description:

  • Added testcase for Prometheus core metrics to cover the start_timestamp reset issue.
  • Modified isFirstFailedScrape method to validate first failed scrape on the basis of datapoint flags supported by OTLP format for staleness markers. For now skipped this validation with comment, as current Prometheus Receiver metric builder is not currently setting flags.
  • Modified testComponent method to accept custom receiver configs. This is required to avoid multiple copies of this function (because of custom configs).
  • Modified other tests to remove testComponent copy and use method testComponent in metric_receiver_helper_test.go

Link to tracking Issue:
Issue Number: #6000
cc @alolita @Aneurysm9

@PaurushGarg PaurushGarg requested review from Aneurysm9 and a team as code owners December 9, 2021 23:52
@PaurushGarg PaurushGarg changed the title Added testcases for default metrics and resolved feedback [Prometheus Receiver] Added testcase for core Prometheus metrics Dec 9, 2021
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Dec 10, 2021
@bogdandrutu bogdandrutu merged commit 08ed4f5 into open-telemetry:main Dec 10, 2021
@PaurushGarg PaurushGarg deleted the issue-6000-prom-receiver-test-default-metrics branch December 18, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants