Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awskinesis] Ensure Validate implementation does the right thing #7835

Closed
codeboten opened this issue Feb 11, 2022 · 1 comment
Closed

[exporter/awskinesis] Ensure Validate implementation does the right thing #7835

codeboten opened this issue Feb 11, 2022 · 1 comment
Labels
comp:aws AWS components good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

This change in the collector core added a Validate method to QueueSettings which caused ambiguity with the ExporterSettings’ Validate method. As a result, I’ve added a Validate method to this exporter and an issue to ensure it was doing the right thing.

Here is an example of the validate method for the OTLP exporter calling the QueueSettings’ Validate

open-telemetry/opentelemetry-collector@48c402d#diff-a56037437974f775001642d59880ac9dd0c14cab137576b4f4a6df01a230a84cR39-R42

Originally posted by @codeboten in #7779 (comment)
@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers comp:aws AWS components labels Feb 11, 2022
sethAmazon referenced this issue in sethAmazon/opentelemetry-collector-contrib Feb 14, 2022
@sethAmazon
Add Queue Config Validation AWS Kinesis Exporter Fixes (#7835)
4529edf
@sethAmazon sethAmazon mentioned this issue Feb 14, 2022
Merged
sethAmazon referenced this issue in sethAmazon/opentelemetry-collector-contrib Feb 14, 2022
@sethAmazon
Add Queue Config Validation AWS Kinesis Exporter Fixes (#7835)
bc942fd
sethAmazon referenced this issue in sethAmazon/opentelemetry-collector-contrib Feb 14, 2022
@sethAmazon
Add Queue Config Validation AWS Kinesis Exporter Fixes (#7835)
723743c
@codeboten
Copy link
Contributor Author

This was done in #7914

ZahidMirza95 pushed a commit to ZahidMirza95/opentelemetry-collector-contrib that referenced this issue Jun 21, 2023
@Chinwendu20
Add validate command to validate collector config (open-telemetry#7835)
463711f 
This is bringing back the functionality initially submitted in @Chinwendu20's PR: open-telemetry/opentelemetry-collector#6445

Adds a validate method which validates the configuration

Link to tracking Issue: open-telemetry/opentelemetry-collector#4613

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Maureen <amaka013@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:aws AWS components good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codeboten