Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make "/metrics" for prometheusexporter configurable #8810

Closed
jixiuf opened this issue Mar 23, 2022 · 4 comments
Closed

make "/metrics" for prometheusexporter configurable #8810

jixiuf opened this issue Mar 23, 2022 · 4 comments
Labels
comp:prometheus Prometheus related issues enhancement New feature or request

Comments

@jixiuf
Copy link

jixiuf commented Mar 23, 2022

Is your feature request related to a problem? Please describe.
make "/metrics" for prometheusexporter configurable in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/prometheusexporter/prometheus.go#L75
@jpkrohling
Copy link
Member

cc @Aneurysm9

@jpkrohling jpkrohling added enhancement New feature or request comp:prometheus Prometheus related issues labels Mar 23, 2022
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this issue Apr 12, 2022
@gouthamve
[prometheusexporter] Make metrics path configurable
9c52472 
Fixes open-telemetry#8810

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve mentioned this issue Apr 12, 2022
Closed
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this issue Apr 12, 2022
@gouthamve
[prometheusexporter] Make metrics path configurable
1db4917 
Fixes open-telemetry#8810

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this issue May 3, 2022
@gouthamve
[prometheusexporter] Make metrics path configurable
bd62762 
Fixes open-telemetry#8810

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this issue May 3, 2022
@gouthamve
[prometheusexporter] Make metrics path configurable
958ce9c 
Fixes open-telemetry#8810

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this issue May 3, 2022
@gouthamve
[prometheusexporter] Make metrics path configurable
7a8948a 
Fixes open-telemetry#8810

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve
Copy link
Member

Hi, I opened a PR #9239 to fix this, but could you elaborate on your usecase @jixiuf? What would you like to achieve that is not possible right now?

@jixiuf
Copy link
Author

jixiuf commented May 6, 2022

that PR is ok for me， thanks.

@jixiuf jixiuf closed this as completed May 6, 2022
@gouthamve
Copy link
Member

Hi, @jixiuf Sorry that I am only seeing this now, was away the past few weeks.

The discussion on the PR suggests that the change might not be required. Could you elaborate on the usecase so we can merge the PR?

@gouthamve gouthamve mentioned this issue Jun 21, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:prometheus Prometheus related issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[prometheusexporter] Make metrics path configurable gouthamve/opentelemetry-collector-contrib
3 participants
@jpkrohling @jixiuf @gouthamve