[cmd/mdatagen] Work around a go-generate issue blocking make generate #10133
Conversation
dmitryax
requested review from
a team,
djaglowski,
pmm-sumo and
dashpole
as code owners
|
Does it make sense to do this since we can maybe drop the "_v2" from the file name, now that we are close to make transition to all? |
This actually helps to rename of all the files by running |
|
I'm ok to keep it as is but that error was too annoying so I wanted to get rid of it |
|
@bogdandrutu what's your thought on this? Can we merge it? I think it's good to have it to avoid confusing failures that still possibly can arise. I don't see downsides except for the 3 more lines in the generated code. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
force-pushed
the
workaround-go-gen-issue
branch
from
4378468
to
f80c75e
Compare
…s builder, running `go generate ./...` ends up with a failure `no such file or directory` even if the `mdatagen` command successfully completed. The root cause of that is in how go generate works. This change adds a workaround for the issue using go build tags.
dmitryax
force-pushed
the
workaround-go-gen-issue
branch
from
f80c75e
to
f0f0cb1
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
If
mdatagenis causing file renames, e.g. migration to the new metrics builder, runninggo generate ./...ends up with a failureno such file or directoryeven if themdatagencommand successfully completed. The root cause of that is in howgo generateworks, see golang/go#36068. This change adds a workaround for the issue using go build tags.