[processor/transform] Update is_monotonic and aggregation_temporality accessor functions #10197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
a team,
Aneurysm9 and
bogdandrutu
as code owners
|
/cc @anuraaga |
anuraaga
approved these changes
May 23, 2022
pmm-sumo
approved these changes
May 23, 2022
|
@open-telemetry/collector-contrib-maintainer please review. I'd like to get this in for the 0.52.0 release |
djaglowski
approved these changes
May 23, 2022
aggregation_temporality is the protobuf name of the field right? What convention is being broken? |
|
Oops, crossed wires. I see that it's exactly as it should be. 👍 |
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
… accessor functions (open-telemetry#10197) * Update accessor functions * Update readme * Update changelog * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The access functions for metric's is_monotonic and aggregation_temporality fields were using the pmetric versions, but this didn't work in practice since the grammar doesn't know how to convert the incoming string to the exact pmetric equivalent.
Instead, I have updated the getters and setters to convert the pmetric type to an equivalent data type that the parser understands. This will allow the following scenarios to work:
Changing temporality:
set(metric.aggregation_temporality, 1) where metric.aggregation_temporality == 0Changing monotonicity:
set(metric.is_monotonic, "true") where metric.is_monotonic == "false"Testing:
Updated existing scenarios and added new test scenarios.
Documentation:
Updated readme.