-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jmx metrics extension: Initial subprocess manager #1028
jmx metrics extension: Initial subprocess manager #1028
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
===========================================
+ Coverage 73.67% 89.74% +16.07%
===========================================
Files 22 275 +253
Lines 1018 13510 +12492
===========================================
+ Hits 750 12125 +11375
- Misses 217 1016 +799
- Partials 51 369 +318
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bogdandrutu @tigrannajaryan any chance one of you could take a look at this? |
This is now the 3rd instance of a subprocess manager code, right? Perhaps time to actually make it a lib? |
@tigrannajaryan this subprocess manager doesn't have robust restart configuration or a persistent stdin mechanism (just writes once). I'd be happy to begin the process of porting this over to collector core but would really appreciate not being blocked on this extension's actual implementation by that work. |
Here is an example snippet that will not report tracing without this patch: with psycopg2.connect(...) as conn, conn.cursor() as cursor: cursor.execute("select 1;") Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
Here is an example snippet that will not report tracing without this patch: with psycopg2.connect(...) as conn, conn.cursor() as cursor: cursor.execute("select 1;") Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
Here is an example snippet that will not report tracing without this patch: with psycopg2.connect(...) as conn, conn.cursor() as cursor: cursor.execute("select 1;") Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
Here is an example snippet that will not report tracing without this patch: with psycopg2.connect(...) as conn, conn.cursor() as cursor: cursor.execute("select 1;") Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
Description:
Adding a feature - adding a subprocess manager to the jmx metrics extension that will be capable of managing child java processes. This is largely a port of https://github.com/open-telemetry/opentelemetry-collector/blob/master/extension/fluentbitextension/process.go and could potentially be relocated to collector core to satisfy open-telemetry/opentelemetry-collector#1492 in the future.
Link to tracking Issue:
Testing: Integration and unit tests
Documentation: None required, other than changelog that will occur later.