Add SignalFx Event Support to SignalFx Exporter #1036
Conversation
| // avoid attempting to compress things that fit into a single ethernet frame | ||
| func (s *sfxClientBase) getReader(b []byte) (io.Reader, bool, error) { | ||
| var err error | ||
| if len(b) > 1500000 { |
There was a problem hiding this comment.
1500000 does not appear to be a single ethernet frame size. I am probablly missing something. AFAIK MTU is typically 1500 (jumbo frames can go up to 9000).
There was a problem hiding this comment.
Yeah not sure how that got changed, will fix.
|
@keitwb the build is failing, please check. |
|
The code lgtm, but need to fix the build errors. |
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
+ Coverage 88.88% 88.92% +0.03%
==========================================
Files 254 256 +2
Lines 12150 12306 +156
==========================================
+ Hits 10800 10943 +143
- Misses 1003 1011 +8
- Partials 347 352 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Fix the conflicts. |
| }) | ||
|
|
||
| event.EventType = lr.Name() | ||
| event.Timestamp = int64(lr.Timestamp()) / 1e6 |
There was a problem hiding this comment.
Add comment to explain time unit conversion (1e6 is not clear).
This consumes the logs generated by the SignalFx receiver that come from events.
The goal is to understand who is using the OpenTelemetry Collector in production. Other CNCF projects have taken a similar approach to highlight adoption.
This consumes the logs generated by the SignalFx receiver that
come from events.
Ignore the first commit and only focus on the second. It contains dependent code from #1035 that this PR depends on to build properly.