Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement googlemanagedprometheus exporter #10925

Merged
merged 1 commit into from Jun 15, 2022

Conversation

dashpole
Copy link
Contributor

Description:

Fixes #10543

The googlemanagedprometheus exporter is an exporter for Google Cloud Monitoring that uses a custom domain prefix (prometheus.googleapis.com), a fixed monitored resource (prometheus_target), and adds type suffixes to the metric name. Utility functions for mapping to prometheus_target and adding type suffixes are provided by https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/main/exporter/collector/googlemanagedprometheus.

This is implemented by defining the GMPConfig with fewer options than the standard googlecloud exporter, and defining a conversion function to allow using the googlecloud exporter library.

Testing:

Added unit tests, which are modeled after those found in https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/googlecloudexporter

Documentation:

Updated README.md

@project-bot project-bot bot added this to In progress in Collector Jun 13, 2022
@dashpole dashpole marked this pull request as ready for review June 13, 2022 17:47
@dashpole dashpole requested review from a team, jsuereth and punya as code owners June 13, 2022 17:47
@dashpole dashpole requested a review from codeboten June 13, 2022 17:47
Collector automation moved this from In progress to Reviewer approved Jun 15, 2022
@djaglowski djaglowski merged commit 3221691 into open-telemetry:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Reviewer approved
Development

Successfully merging this pull request may close these issues.

New component: Google Managed service for Prometheus exporter
3 participants