Don't set origin to EC2 when not on AWS. #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
===========================================
+ Coverage 73.67% 88.98% +15.31%
===========================================
Files 22 258 +236
Lines 1018 12333 +11315
===========================================
+ Hits 750 10975 +10225
- Misses 217 1008 +791
- Partials 51 350 +299
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wangzlei
reviewed
Sep 25, 2020
| if resource.IsNil() { | ||
| return OriginEC2 | ||
| return "" |
…ector-contrib into no-aws-on-non-aws-origin
tigrannajaryan
approved these changes
Sep 28, 2020
|
Please fix the conflict and make sure the build passes. |
…ector-contrib into no-aws-on-non-aws-origin
|
@tigrannajaryan Thanks, merged master |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
If ResourceCheckPeriod is more than 1 second, reported resource values are not being changed during each ResourceCheckPeriod, so logging every second doens't provide much value, but makes it hard to read logs in long run running tests
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Change name of ProbabilitySampler to TraceIdRatioBased * Modify behavior to ignore parent span * Add test for inclusivity property on TraceIdRatioBased sampler * Modify tests in `trace_test.go` to reflect change in parent span behavior * Add to CHANGELOG * Satisfy golint * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't only look at semantic attributes for determining AWS origin values since they may be from a different cloud.