Enable awsecscontainermetricsreceiver- update components and go.mod #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 89.97% 89.99% +0.02%
==========================================
Files 283 283
Lines 13772 13772
==========================================
+ Hits 12391 12394 +3
+ Misses 1013 1010 -3
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hi @tigrannajaryan and @bogdandrutu can I get this reviewed and merged. It's just two line change for enabling the receiver. Thanks in advanced. |
go.mod
Outdated
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/client9/misspell v0.3.4 | |||
| github.com/go-lintpack/lintpack v0.5.2 // indirect | |||
| github.com/golangci/golangci-lint v1.31.0 | |||
| github.com/google/addlicense v0.0.0-20200622132530-df58acafd6d5 | |||
| github.com/google/addlicense v0.0.0-20200906110928-a0294312aa76 | |||
There was a problem hiding this comment.
Updated to the old version.
tigrannajaryan
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change will enable the
awsecscontainermetricsreceiverin OT components.Link to tracking Issue:
#457
Testing:
Unit test added.
Documentation:
README added.