internal/splunk: fallback to host if cloud resource id not found #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Oct 1, 2020
I will do in followup PR. I should make internal/splunk its own go module I assume? |
|
Build failed. |
|
Please rebase |
APM correlation will need to do same thing so add fallback logic in common.
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 89.82% 89.77% -0.05%
==========================================
Files 285 285
Lines 13882 13878 -4
==========================================
- Hits 12469 12459 -10
- Misses 1044 1052 +8
+ Partials 369 367 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@tigrannajaryan fixed |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Note: All of the cudos go to @dneray for the logic/testing/effort in open-telemetry/opentelemetry-collector#981 This pr is based off of it with the following modifications - The config looks like ``` - key : <key to use for applying the rule too> pattern: <the regex pattern with named submatchers> action: extract ``` I think that the original PR is going in the right way for what we can the internal logic to be but as the issue #979 and #1170 indicate we need to take a step back and redesign the attributes processor (or make it clear of its limitations). This pr unblocks the required functionality. **Link to tracking Issue:** #979 **Link to follow up issue:** #1170 **Testing:** Added tests for extracting. **Documentation:** Updated processor readme.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…#1170) * Don't consider unset env var an error during detection * update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APM correlation will need to do same thing so add fallback logic in common.