Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Datadog Trace Export Configuration #1181

Merged

Conversation

ericmustin
Copy link
Contributor

Description:
This PR adds Trace export configuration to the Datadog exporter overall structure, following the contributing guidelines.

This adds the configuration necessary to then add the ability to export traces directly to Datadog's backend (agentless).

After the configuration is confirmed we plan to make additional PRs to bring in the actual bulk code for exporting traces. Contribution guidelines state we should break this up, but you can find this work in progress (though functional) here, on the our fork, for context.

You can also find additional work for metric export code in this pr. I don't think these are tightly coupled but happy to rebase if one gets merged before the other.

Any feedback or comments here are welcome and we'll try to prioritise, as well as if you have any feedback on in progress work on our fork. I'm also available on gitter for anything ad-hoc. We're keen to get both the metric and trace code into the collector and support it however necessary.

Cheers, Eric

Link to tracking Issue:

Testing: Added unit tests, tested full version (available on our fork) on an end to end testing environment.

Documentation: This adds the README for the exporter with the intended instructions for the full trace exporter.

@ericmustin ericmustin requested a review from a team as a code owner October 2, 2020 13:52
@project-bot project-bot bot added this to In progress in Collector Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #1181 into master will increase coverage by 13.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1181       +/-   ##
===========================================
+ Coverage   76.01%   89.96%   +13.95%     
===========================================
  Files          24      283      +259     
  Lines        1163    13782    +12619     
===========================================
+ Hits          884    12399    +11515     
- Misses        226     1014      +788     
- Partials       53      369      +316     
Flag Coverage Δ
#integration 76.09% <ø> (+0.08%) ⬆️
#unit 89.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/datadogexporter/config.go 92.30% <100.00%> (ø)
exporter/datadogexporter/factory.go 100.00% <100.00%> (ø)
exporter/sentryexporter/utils.go 100.00% <0.00%> (ø)
exporter/awsxrayexporter/factory.go 100.00% <0.00%> (ø)
receiver/k8sclusterreceiver/collection/replica.go 100.00% <0.00%> (ø)
...stransformprocessor/metrics_transform_processor.go 100.00% <0.00%> (ø)
extension/observer/endpointswatcher.go 93.75% <0.00%> (ø)
exporter/azuremonitorexporter/conventions.go 100.00% <0.00%> (ø)
...sformprocessor/operation_toggle_scalar_datatype.go 64.28% <0.00%> (ø)
...sreceiver/awsecscontainermetrics/stats_provider.go 100.00% <0.00%> (ø)
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450f782...0fe6540. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Oct 3, 2020
@bogdandrutu bogdandrutu merged commit 3402ddf into open-telemetry:master Oct 3, 2020
Collector automation moved this from Reviewer approved to Done Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants