Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mongodb] Respect TLS in all situations #12093

Merged
merged 8 commits into from
Jul 6, 2022

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented Jul 5, 2022

Description:
Resolves #12092

Link to tracking Issue:
#12092

Testing:
Manually tested/working on unit test

Documentation: unreleased yaml file added for bug fix

@schmikei schmikei marked this pull request as ready for review July 5, 2022 21:35
@schmikei schmikei requested review from a team and djaglowski as code owners July 5, 2022 21:35
@schmikei
Copy link
Contributor Author

schmikei commented Jul 6, 2022

@djaglowski do you mind taking a look at this?

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one question.

receiver/mongodbreceiver/testdata/certs/ca-1.cert Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@djaglowski djaglowski merged commit ebc03dd into open-telemetry:main Jul 6, 2022
@djaglowski djaglowski deleted the mongo-respect-tls branch July 6, 2022 15:12
Konig-Corey pushed a commit to Konig-Corey/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2022
* fix tls issue for mongodbreceiver

* add unreleased yaml

* add test case

* integration test uses insecure true

* add mongodbreceiver certs to Makefile generation

* Update Makefile

* revert receiver/mongodbatlasreceiver/testdata/alerts/certs => receiver/mongodbatlasreceiver/testdata/alerts/cert

* Update Makefile
atoulme pushed a commit to atoulme/opentelemetry-collector-contrib that referenced this pull request Jul 16, 2022
* fix tls issue for mongodbreceiver

* add unreleased yaml

* add test case

* integration test uses insecure true

* add mongodbreceiver certs to Makefile generation

* Update Makefile

* revert receiver/mongodbatlasreceiver/testdata/alerts/certs => receiver/mongodbatlasreceiver/testdata/alerts/cert

* Update Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/mongodb] TLS Settings Ignored in certain circumstances
3 participants