[pkg/stanza] Remove helper.Duration #13439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-rm-duration
branch
4 times, most recently
from
a243413
to
047c4da
Compare
This struct was a wrapper around time.Duration, for the sole purpose of providing a default unit (s) for users. It is not used elsewhere in the collector and does not need to be used here either.
djaglowski
force-pushed
the
pkg-stanza-rm-duration
branch
from
047c4da
to
b858a14
Compare
dashpole
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct was a wrapper around time.Duration, for the sole
purpose of providing a default unit (s) for users. It is not
used elsewhere in the collector and does not need to be used
here either.