[exporter/sumologic] Mark exporter as mutating data #13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
make-sumologic-exporter-mutating
branch
from
df77639
to
213f157
Compare
The exporter mutates the logs data. In order to avoid affecting other exporters configured along side, the exporter has to be marked as mutating data so all pdata is copied over.
bogdandrutu
approved these changes
Aug 26, 2022
dmitryax
force-pushed
the
make-sumologic-exporter-mutating
branch
from
213f157
to
3287170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter mutates the logs data at least in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/sumologicexporter/exporter.go#L171 and https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/sumologicexporter/exporter.go#L314
In order to avoid affecting other exporters configured alongside, the exporter should be marked as mutating data so all pdata is copied over.
Link to tracking Issue: #13646