[pkg/telemetryquerylanguage] Unexport unnessessary functions and types #13737
Conversation
| want func(pmetric.MetricSlice) | ||
| } | ||
|
|
||
| func Test_ConvertSummarySumValToSum(t *testing.T) { |
There was a problem hiding this comment.
These 2 test files should've been using the function directly but were still calling NewFunctionCall. They are now in line with how we test other functions.
There was a problem hiding this comment.
Since this PR focuses on the TQL package's public interface, I think it may be worth adding a section in the readme to describe how to use the TQL in a component, as it's not immediately obvious when looking through the docs in the repo or the published docs. However, that change isn't essential here and may be large enough in scope to make more sense in another PR.
|
@evan-bradley I agree, the public docs for the actual interface of the package is lacking. @bogdandrutu addressed that problem in the linked issue and I plan to tackle it in its entirety in a separate PR. |
|
Need rebase |
|
@bogdandrutu merge conflicts handled |
open-telemetry#13737) This PR unexports several functions and types that do not need to be exposed
Description:
This PR unexports several functions and types that do not need to be exposed
Link to tracking Issue:
Works towards #13690
Testing:
Unit Tests