[receiver/dockerstats] For V2 implementation, create sensible enabled defaults #14093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
Sep 13, 2022
rmfitzpatrick
approved these changes
Sep 15, 2022
|
@TylerHelmuth this has your approval, codeowner, plus one more. Please merge whenever possible 🙂 |
TylerHelmuth
added
the
ready to merge
codeboten
approved these changes
Sep 16, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
Sep 19, 2022
… defaults (open-telemetry#14093) This is not a breaking change unless you are using the non-default V2 scraper which is behind a feature gate. Currently almost every metric is enabled by default, which was done to demonstrate feature parity with the original V1 scraper which enables almost everything by default. This changes so most metrics are not enabled by default, and instead a sensible set of defaults are enabled. There are many very detailed memory and block IO metric that 99% of users will never need, and all it does it consume needless MTS. The change brings the default set of metrics from 63 to 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is not a breaking change unless you are using the non-default V2 scraper which is behind a feature gate.
Currently almost every metric is enabled by default, which was done to demonstrate feature parity with the original V1 scraper which enables almost everything by default.
This changes so most metrics are not enabled by default, and instead a sensible set of defaults are enabled. There are many very detailed memory and block IO metric that 99% of users will never need, and all it does it consume needless MTS.
The change brings the default set of metrics from 63 to 14.
The new list of enabled metrics by default is below. I made it similar to the defaults of the signalfx agent. I am open to suggestions on changes here.
container.cpu.usage.systemcontainer.cpu.usage.totalcontainer.cpu.usage.kernelmodecontainer.cpu.usage.usermodecontainer.cpu.percentcontainer.memory.usage.limitcontainer.memory.usage.totalcontainer.memory.percentcontainer.memory.total_cachecontainer.blockio.io_service_bytes_recursivecontainer.network.io.usage.rx_bytescontainer.network.io.usage.tx_bytescontainer.network.io.usage.rx_droppedcontainer.network.io.usage.tx_droppedLink to tracking Issue:
#9794
Testing:
All unit tests still test 100% of the metrics.
Documentation:
Documentation automatically updated by
go generateandmdatagen.