-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awsxray] Favour semconv attributes for QueueURL and TableName #16076
Conversation
Pinging @willarmiros as code owner |
@willarmiros please could you take a look at this PR 😄 thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general this LGTM, just am having a hard time reading our own code and want a sanity check :)
Thank you very much for the contributions though! If you were so inclined, it would be very helpful to update our translation documentation as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…me (open-telemetry#16076) * [exporter/awsxray] Favour semconv attributes when populating Queue URL and Table Name * Fix linter complaint about spelling * Reinstate redundant test code
…me (open-telemetry#16076) * [exporter/awsxray] Favour semconv attributes when populating Queue URL and Table Name * Fix linter complaint about spelling * Reinstate redundant test code
Description:
THe AWS X-Ray Exporter does not use semantic convention attributes when attempting to populate the
queueURL
andtableName
attributes. Instead it only looks for the X-Ray custom attributes. This PR extends the behaviour to favour the semantic convention attributes (if set). This was motivated by the recent discussion on the PR that extended the AWS-SDK-Go-v2 instrumentation libraryotelaws
. See discussion. (cc. @Aneurysm9)Link to tracking Issue: #16075