Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheus] Make the exporter not mutating #16572

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 1, 2022

by removing an unnecessary Sort method.

This is also one of the prerequisites for open-telemetry/opentelemetry-collector#6660

@dmitryax dmitryax requested review from a team and Aneurysm9 as code owners December 1, 2022 19:07
@dmitryax dmitryax force-pushed the prom-exporter-doesnt-mutate-metrics branch from a3c45f2 to 4c47fce Compare December 1, 2022 19:08
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 1, 2022
@runforesight
Copy link

runforesight bot commented Dec 1, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 33 minutes 8 seconds compared to main branch avg(33 minutes 12 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (33 minutes 8 seconds less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
windows-unittest -     🔗  N/A See Details
windows-unittest-matrix -     🔗  N/A See Details

✅  check-links workflow has finished in 38 seconds (1 minute 32 seconds less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

⭕  changelog workflow has finished in 3 seconds (4 minutes 59 seconds less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  tracegen workflow has finished in 59 seconds (1 minute 24 seconds less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 15 seconds (4 minutes 56 seconds less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 39 minutes 21 seconds (15 minutes 9 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.18, internal) -     🔗  ✅ 591  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 525  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 591  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2411  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2411  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 525  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4345  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1832  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4336  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1832  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
checks -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 8 minutes 11 seconds (6 minutes 1 second less than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗
loadtest (TestTraceNoBackend10kSPS TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗
loadtest (TestMetricResourceProcessor TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗
loadtest (TestTraceBallast1kSPSWithAttrs TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗
loadtest (TestBallastMemory TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax changed the title [exporter/prometheus] Make the exporter doesn't mutate metrics [exporter/prometheus] Make the exporter not mutating Dec 1, 2022
@dmitryax dmitryax force-pushed the prom-exporter-doesnt-mutate-metrics branch from 4c47fce to 23f9d9f Compare December 1, 2022 19:35
@dmitryax dmitryax force-pushed the prom-exporter-doesnt-mutate-metrics branch from 23f9d9f to 618c426 Compare December 1, 2022 23:33
@bogdandrutu bogdandrutu merged commit c6a474d into open-telemetry:main Dec 2, 2022
@dmitryax dmitryax deleted the prom-exporter-doesnt-mutate-metrics branch December 3, 2022 10:22
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…16572)

[exporter/prometheus] Make the exporter doesn't mutate metrics

by removing unnecessary Sort method
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/prometheus Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants