Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch]: Add node version as a resource attribute #16831

Conversation

davidji99
Copy link
Contributor

@davidji99 davidji99 commented Dec 9, 2022

#16847

Add elasticsearch.node.version to all elasticsearch metrics.

@runforesight
Copy link

runforesight bot commented Dec 9, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 46 minutes 52 seconds compared to main branch avg(46 minutes 56 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (46 minutes 52 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 7 seconds (3 minutes 23 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 30 seconds (2 minutes 31 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 26 seconds (6 minutes 7 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 39 seconds (6 minutes 51 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 37 minutes (23 minutes 15 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 595  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 595  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1476  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1476  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2563  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2563  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2450  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4397  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4397  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1886  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2450  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1886  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 8 minutes 9 seconds (10 minutes 29 seconds less than main branch avg.) and finished at 3rd Jan, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@davidji99 davidji99 marked this pull request as ready for review December 9, 2022 04:12
@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch 2 times, most recently from e0a3107 to e4f1c59 Compare December 9, 2022 05:31
@djaglowski
Copy link
Member

This seems like a reasonable attribute to add, but I'm not sure how it relates to the tracking issue you linked.

More importantly, this will be considered a breaking change, so needs to go behind a feature gate: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/scraping-receivers.md#other-changes

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch 3 times, most recently from 05a1261 to bd0190f Compare December 12, 2022 06:44
@davidji99
Copy link
Contributor Author

Added the new resource attribute behind a gate @djaglowski

Build is failing due to #16846

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch from bd0190f to d2b32b8 Compare December 12, 2022 07:05
@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch from d2b32b8 to 18d037d Compare December 12, 2022 23:02
@davidji99
Copy link
Contributor Author

@djaglowski

In addressing #16831 (comment), I realized node version is not returned by the /nodes/_stats endpoint but rather /nodes endpoint. So, I've updated the code and tests to reflect this additional API call. Please review.

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch from 18d037d to e5c774b Compare December 13, 2022 23:07
@davidji99
Copy link
Contributor Author

Updated @djaglowski

@davidji99 davidji99 changed the title [receiver/elasticsearchreceiver]: Add node version as a resource attribute [receiver/elasticsearch]: Add node version as a resource attribute Dec 14, 2022
receiver/elasticsearchreceiver/scraper.go Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/scraper.go Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/scraper.go Outdated Show resolved Hide resolved
@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch 3 times, most recently from d06a0f8 to 706c4a0 Compare December 15, 2022 05:47
@davidji99
Copy link
Contributor Author

Updated @djaglowski

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch from 706c4a0 to 36c7483 Compare December 19, 2022 21:03
@davidji99
Copy link
Contributor Author

@djaglowski review again when you can.

@djaglowski
Copy link
Member

Please rebase

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch 7 times, most recently from 7fdbce4 to 6940a2e Compare January 3, 2023 10:32
@djaglowski
Copy link
Member

Unfortunately, we'll need another rebase due to a test failure on main.

@davidji99 davidji99 force-pushed the elasticsearch-add-clustersetting-metrics branch from 6940a2e to 72fd20d Compare January 3, 2023 21:36
@davidji99
Copy link
Contributor Author

@djaglowski Updated.

@djaglowski djaglowski merged commit 10b851a into open-telemetry:main Jan 4, 2023
@davidji99 davidji99 deleted the elasticsearch-add-clustersetting-metrics branch January 4, 2023 20:34
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants