[receiver/kafkareceiver] support zipkin_json(v1) #17186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes made are zipkin_unmarshaler.go 1. added new function newZipkinJSONv1Unmarshaler 2. added const zipkinJSONv1Encoding zipin_marshaler_test.go 1.commented possible changes unmarshaler.go 1.added zipkinJSONv1 to defaultTracesUnmarshalers() unmarshaler_test.go 1.updated tests
Subhasish-Behera
requested review from
a team and
MovieStoreGuy
as code owners
|
|
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 5 seconds (44 minutes 51 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 1 minute 1 second (2 minutes 57 seconds less than main branch avg.) and finished at 28th Dec, 2022.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 1 minute 25 seconds (2 minutes 10 seconds less than main branch avg.) and finished at 28th Dec, 2022.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 2 minutes 22 seconds (5 minutes 41 seconds less than main branch avg.) and finished at 28th Dec, 2022.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 10 minutes 58 seconds and finished at 28th Dec, 2022.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
❌ build-and-test workflow has finished in 24 minutes 43 seconds (33 minutes 43 seconds less than main branch avg.) and finished at 28th Dec, 2022. 2 jobs failed.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, internal) | - 🔗 | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, internal) | - 🔗 | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, processor) | - 🔗 | ✅ 1474 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, processor) | - 🔗 | ✅ 1474 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, receiver-0) | - 🔗 | ✅ 2564 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2564 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2447 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, other) | - 🔗 | ✅ 4395 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1886 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, other) | - 🔗 | ✅ 4395 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, exporter) | - 🔗 | ✅ 2447 ❌ 0 ⏭ 0 🔗 | See Details |
| integration-tests | - 🔗 | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, receiver-1) | - 🔗 | ✅ 1886 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
| lint-matrix (receiver-0) | Lint 🔗 | N/A | See Details |
| lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
| lint-matrix (processor) | - 🔗 | N/A | See Details |
| lint-matrix (exporter) | - 🔗 | N/A | See Details |
| lint-matrix (extension) | - 🔗 | N/A | See Details |
| lint-matrix (internal) | - 🔗 | N/A | See Details |
| lint-matrix (other) | - 🔗 | N/A | See Details |
| check-collector-module-version | - 🔗 | N/A | See Details |
| checks | - 🔗 | N/A | See Details |
| check-codeowners | - 🔗 | N/A | See Details |
| build-examples | - 🔗 | N/A | See Details |
| lint | Interpret result 🔗 | N/A | See Details |
| unittest (1.19) | - 🔗 | N/A | See Details |
| unittest (1.18) | - 🔗 | N/A | See Details |
| windows-msi | - 🔗 | N/A | See Details |
| build-package | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
| publish-check | - 🔗 | N/A | See Details |
| publish-dev | - 🔗 | N/A | See Details |
| cross-compile | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 28 minutes 57 seconds (⚠️ 11 minutes 39 seconds more than main branch avg.) and finished at 28th Dec, 2022.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
Comment on lines
+98
to
+103
| //{ | ||
| // unmarshaler: newZipkinJSONv1Unmarshaler(), | ||
| // encoding: "zipkin_v1json", | ||
| // bytes: jsonv1Bytes, | ||
| // expected: td, | ||
| //}, |
There was a problem hiding this comment.
I would prefer not having commented out code in the test, is there a reason for having this?
Comment on lines
+127
to
+131
| //func TestUnmarshalZipkinJSONv1_error(t *testing.T) { | ||
| // p := newZipkinJSONv1Unmarshaler() | ||
| // _, err := p.Unmarshal([]byte("+$%")) | ||
| // assert.Error(t, err) | ||
| //} |
There was a problem hiding this comment.
Uncomment this and add it to the test being run.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Hey @Subhasish-Behera , are you still working on this? |
|
https://cloud-native.slack.com/archives/CJFCJHG4Q/p1671807742419309?thread_ts=1671515726.873829&cid=CJFCJHG4Q |
|
@MovieStoreGuy ,@pavolloffay,@TylerHelmuth not sure why this PR was closed. I want to start working on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
changes made are : zipkin_unmarshaler.go 1. added new function newZipkinJSONv1Unmarshaler 2. added const zipkinJSONv1Encoding zipkin_marshaler_test.go 1. commented possible test unmarshaler.go 1.added zipkinJSONv1 to defaultTracesUnmarshalers() unmarshaler_test.go 1.updated testsLink to tracking Issue:
#14472
Testing:
Documentation: