Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add promtail receiver to otelcontribcol #18225

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Feb 1, 2023

Description:
Add promtail receiver to otelcontribcol

Link to tracking Issue: fix #17082

@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Feb 1, 2023
@runforesight
Copy link

runforesight bot commented Feb 1, 2023

Foresight Summary

    
Major Impacts

TestRiakIntegration ❌ failed 1 times in 3 runs (33% fail rate).
build-and-test-windows duration(6 seconds) has decreased 40 minutes 5 seconds compared to main branch avg(40 minutes 11 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 6 seconds (40 minutes 5 seconds less than main branch avg.) and finished at 6th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

⭕  changelog workflow has finished in 5 seconds (2 minutes 1 second less than main branch avg.) and finished at 6th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 2 minutes 5 seconds and finished at 6th Feb, 2023.


Job Failed Steps Tests
publish-stable -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 59 seconds and finished at 6th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 12 minutes 27 seconds (⚠️ 4 minutes 35 seconds more than main branch avg.) and finished at 6th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

❌  build-and-test workflow has finished in 30 minutes 47 seconds (23 minutes 56 seconds less than main branch avg.) and finished at 6th Feb, 2023. 1 job failed. There are 1 test failures.


Job Failed Steps Tests
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 546  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1472  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 546  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1472  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2578  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2578  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2444  ❌ 0  ⏭ 0    🔗 See Details
integration-tests Run Integration Tests     🔗  ✅ 45  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1958  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2444  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4672  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1958  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4672  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile -     🔗  N/A See Details
build-package -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-check -     🔗  N/A See Details

✅  load-tests workflow has finished in 22 minutes 42 seconds (⚠️ 7 minutes 52 seconds more than main branch avg.) and finished at 6th Feb, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@mar4uk mar4uk marked this pull request as ready for review February 1, 2023 15:38
@mar4uk mar4uk requested a review from a team as a code owner February 1, 2023 15:38
Comment on lines 54 to 58
type PromtailInputConfig struct {
PositionsConfig positions.Config `mapstructure:"positions,omitempty" yaml:"positions,omitempty"`
ScrapeConfig []scrapeconfig.Config `mapstructure:"scrape_configs,omitempty" yaml:"scrape_configs,omitempty"`
TargetConfig file.Config `mapstructure:"target_config,omitempty" yaml:"target_config,omitempty"`
PositionsConfig positions.Config `mapstructure:"-" yaml:"positions,omitempty"`
ScrapeConfig []scrapeconfig.Config `mapstructure:"-" yaml:"scrape_configs,omitempty"`
TargetConfig file.Config `mapstructure:"-" yaml:"target_config,omitempty"`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@mar4uk mar4uk Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test

func TestValidateConfigs(t *testing.T) {
failed because inner structs don't have mapstructure tags, they only have yaml tags.

Since promtail config has its own Unmarshall method that uses yaml.Marshal, yaml.Unmarshal methods, mapstructure tag is not needed here

@mar4uk mar4uk force-pushed the add-promtail-receiver-to-otelcontribcol branch from 1babd8e to 076b02a Compare February 6, 2023 10:40
@mar4uk mar4uk closed this Feb 8, 2023
@mar4uk mar4uk deleted the add-promtail-receiver-to-otelcontribcol branch February 8, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command receiver/promtail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receiver/promtailreceiver not in release v0.67.0
4 participants