[processor/transform] Fix issue where ErrorMode wasn't used. #19629

TylerHelmuth · 2023-03-13T20:09:36Z

Description:
In #18693 I forgot to actually use ErrorMode 🤦

This PR updates the transformprocessor so it actually respects the value of error_mode instead of hard coding Propagate.

Testing:

Update factory tests to run a statement that causes an error that is ignored when using ottl.IgnoreError. Updated processor tests to test both modes.

runforesight · 2023-03-13T20:10:50Z

Foresight Summary

Major Impacts

build-and-test duration(5 minutes 58 seconds) has decreased 58 minutes 59 seconds compared to main branch avg(1 hour 4 minutes 57 seconds).

View More Details

⭕ build-and-test-windows workflow has finished in 6 seconds (42 minutes 48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

✅ check-links workflow has finished in 47 seconds (43 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 5 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ changelog workflow has finished in 1 minute 31 seconds (48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 3 minutes 9 seconds (4 minutes 24 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ load-tests workflow has finished in 6 minutes 43 seconds (6 minutes 36 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 18 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

✅ e2e-tests workflow has finished in 11 minutes 11 seconds (4 minutes 2 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
kubernetes-test (v1.26.0)	- 🔗	N/A	See Details
kubernetes-test (v1.25.3)	- 🔗	N/A	See Details
kubernetes-test (v1.24.7)	- 🔗	N/A	See Details
kubernetes-test (v1.23.13)	- 🔗	N/A	See Details

✅ build-and-test workflow has finished in 5 minutes 58 seconds (58 minutes 59 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

Job	Failed Steps	Tests
build-package (deb)	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

TylerHelmuth · 2023-03-13T20:36:20Z

processor/transformprocessor/internal/common/logs.go

@@ -60,7 +60,6 @@ func (l logStatements) ConsumeLogs(ctx context.Context, ld plog.Logs) error {
 type LogParserCollection struct {
 	parserCollection
 	logParser ottl.Parser[ottllog.TransformContext]
-	errorMode ottl.ErrorMode


Doesn't need its own version, it is provided by parserCollection.

Fix issue where ErrorMode wasn't used.

1df24f8

TylerHelmuth requested review from a team, bogdandrutu and evan-bradley as code owners March 13, 2023 20:09

github-actions bot assigned jpkrohling Mar 13, 2023

github-actions bot added the processor/transform Transform processor label Mar 13, 2023

github-actions bot requested a review from kentquirk March 13, 2023 20:10

add changelog

8aec8cb

TylerHelmuth mentioned this pull request Mar 13, 2023

[pkg/ottl] Update functions to use StringGetter #19137

Merged

Add more tests

285b172

TylerHelmuth commented Mar 13, 2023

View reviewed changes

TylerHelmuth requested review from kovrus and djaglowski March 14, 2023 04:55

djaglowski approved these changes Mar 14, 2023

View reviewed changes

TylerHelmuth merged commit dc2f6e1 into open-telemetry:main Mar 14, 2023

TylerHelmuth deleted the tp-fix-error-mode-usage branch March 14, 2023 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[processor/transform] Fix issue where ErrorMode wasn't used. #19629

[processor/transform] Fix issue where ErrorMode wasn't used. #19629

TylerHelmuth commented Mar 13, 2023 •

edited

runforesight bot commented Mar 13, 2023 •

edited

`build-and-test` duration(5 minutes 58 seconds) has decreased 58 minutes 59 seconds compared to main branch avg(1 hour 4 minutes 57 seconds).

⭕ build-and-test-windows workflow has finished in 6 seconds (42 minutes 48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ check-links workflow has finished in 47 seconds (43 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 5 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ changelog workflow has finished in 1 minute 31 seconds (48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 9 seconds (4 minutes 24 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ load-tests workflow has finished in 6 minutes 43 seconds (6 minutes 36 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ e2e-tests workflow has finished in 11 minutes 11 seconds (4 minutes 2 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ build-and-test workflow has finished in 5 minutes 58 seconds (58 minutes 59 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

TylerHelmuth Mar 13, 2023

[processor/transform] Fix issue where ErrorMode wasn't used. #19629

[processor/transform] Fix issue where ErrorMode wasn't used. #19629

Conversation

TylerHelmuth commented Mar 13, 2023 • edited

runforesight bot commented Mar 13, 2023 • edited

Foresight Summary

build-and-test duration(5 minutes 58 seconds) has decreased 58 minutes 59 seconds compared to main branch avg(1 hour 4 minutes 57 seconds).

⭕ build-and-test-windows workflow has finished in 6 seconds (42 minutes 48 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ check-links workflow has finished in 47 seconds (43 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 5 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ changelog workflow has finished in 1 minute 31 seconds (48 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 9 seconds (4 minutes 24 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ load-tests workflow has finished in 6 minutes 43 seconds (6 minutes 36 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ e2e-tests workflow has finished in 11 minutes 11 seconds (4 minutes 2 seconds less than main branch avg.) and finished at 13th Mar, 2023.

✅ build-and-test workflow has finished in 5 minutes 58 seconds (58 minutes 59 seconds less than main branch avg.) and finished at 13th Mar, 2023.

TylerHelmuth Mar 13, 2023

Choose a reason for hiding this comment

TylerHelmuth commented Mar 13, 2023 •

edited

runforesight bot commented Mar 13, 2023 •

edited

`build-and-test` duration(5 minutes 58 seconds) has decreased 58 minutes 59 seconds compared to main branch avg(1 hour 4 minutes 57 seconds).

⭕ build-and-test-windows workflow has finished in 6 seconds (42 minutes 48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ check-links workflow has finished in 47 seconds (43 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 5 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ changelog workflow has finished in 1 minute 31 seconds (48 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 9 seconds (4 minutes 24 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ load-tests workflow has finished in 6 minutes 43 seconds (6 minutes 36 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ e2e-tests workflow has finished in 11 minutes 11 seconds (4 minutes 2 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.

✅ build-and-test workflow has finished in 5 minutes 58 seconds (58 minutes 59 seconds less than `main` branch avg.) and finished at 13th Mar, 2023.