[AzureMonitorExporter] Favor RPC over HTTP spans #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some instrumentation libraries are sending an RPC server span with both RPC and HTTP semantic attributes present (dotnet). In these cases we should favor the RPC attributes when figuring the Span type.
splusq
approved these changes
Jan 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
- Coverage 90.41% 90.41% -0.01%
==========================================
Files 394 394
Lines 19376 19376
==========================================
- Hits 17519 17518 -1
- Misses 1395 1397 +2
+ Partials 462 461 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Jan 13, 2021
pcwiese
referenced
this pull request
in pcwiese/opentelemetry-collector-contrib
Jan 14, 2021
* Bump cloud.google.com/go in /processor/resourcedetectionprocessor (#2003) Bumps [cloud.google.com/go](https://github.com/googleapis/google-cloud-go) from 0.67.0 to 0.75.0. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md) - [Commits](googleapis/google-cloud-go@v0.67.0...v0.75.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Release v0.18.0 (#2008) * [exporter/datadog]: sanitize datadog service names (#1982) * [exporter/datadog]: sanitize service names * [exporter/datadog]: add more test cases and simplify translation logic * [exporter/datadog] add more tests * [datadog/exporter]: linting in tests * Test that default metrics have no tags set other than hostname (#2014) * Update example configuration (#2013) * Add more metadata to awsecscontainer receiver (#2011) * add more metadata to awsecscontainer receiver * use the image.tag instead of image.version for the key value * Fix readme and add test to validate example config (#2000) * Prometheus federation example (#2007) * Add example showing how to use the Prometheus federation endpoint with prometheus_simple * add copyright header to the file * [exporter/datadog]: ensure that version tag is used for stats aggregations, add tests for computing apm stats (#2010) * [AzureMonitorExporter] Favor RPC over HTTP spans (#378) (#2006) Some instrumentation libraries are sending an RPC server span with both RPC and HTTP semantic attributes present (dotnet). In these cases we should favor the RPC attributes when figuring the Span type. * Adding ai.operation.parentid override * Add composite sampling policy in tail sampler * Fix lb exporter issues when DNS resolution fails during startup Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jeff Cheng <jcheng@signalfx.com> Co-authored-by: Eric Mustin <mustin.eric@gmail.com> Co-authored-by: Albert Vaca Cintora <albert.vaca@datadoghq.com> Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com> Co-authored-by: John <59711343+JohnWu20@users.noreply.github.com> Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com> Co-authored-by: Antoine Toulme <atoulme@users.noreply.github.com> Co-authored-by: Pranav Pandit <pranavp@microsoft.com>
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
punya
referenced
this pull request
in punya/opentelemetry-collector-contrib
Jul 21, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some instrumentation libraries are sending an RPC server span with both RPC and HTTP semantic attributes present (dotnet). In these cases, we should favor the RPC attributes when figuring the Span type.
Testing:
E2E testing performed.