Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metadata to awsecscontainer receiver #2011

Merged
merged 2 commits into from Jan 13, 2021

Conversation

JohnWu20
Copy link
Contributor

Description:
Add more metadata to awsecscontainer receiver.

Testing:
United test, end2end test

@project-bot project-bot bot added this to In progress in Collector Jan 13, 2021
@JohnWu20 JohnWu20 marked this pull request as ready for review January 13, 2021 21:56
@JohnWu20 JohnWu20 requested review from anuraaga, kbrockhoff and a team as code owners January 13, 2021 21:56
Copy link
Contributor

@hossain-rayhan hossain-rayhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a minor comment.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #2011 (679d4ef) into master (bb44b79) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.02%     
==========================================
  Files         394      394              
  Lines       19376    19406      +30     
==========================================
+ Hits        17521    17546      +25     
- Misses       1394     1398       +4     
- Partials      461      462       +1     
Flag Coverage Δ
integration 69.73% <ø> (-0.07%) ⬇️
unit 89.19% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...metricsreceiver/awsecscontainermetrics/resource.go 100.00% <100.00%> (ø)
receiver/prometheusexecreceiver/receiver.go 85.83% <0.00%> (-2.50%) ⬇️
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb44b79...679d4ef. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Jan 13, 2021
@bogdandrutu bogdandrutu merged commit 6c499bc into open-telemetry:master Jan 13, 2021
Collector automation moved this from Reviewer approved to Done Jan 13, 2021
@JohnWu20 JohnWu20 deleted the AWSECSzContainerReceiver branch January 14, 2021 00:02
pcwiese referenced this pull request in pcwiese/opentelemetry-collector-contrib Jan 14, 2021
* Bump cloud.google.com/go in /processor/resourcedetectionprocessor (#2003)

Bumps [cloud.google.com/go](https://github.com/googleapis/google-cloud-go) from 0.67.0 to 0.75.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md)
- [Commits](googleapis/google-cloud-go@v0.67.0...v0.75.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Release v0.18.0 (#2008)

* [exporter/datadog]: sanitize datadog service names (#1982)

* [exporter/datadog]: sanitize service names

* [exporter/datadog]: add more test cases and simplify translation logic

* [exporter/datadog] add more tests

* [datadog/exporter]: linting in tests

* Test that default metrics have no tags set other than hostname (#2014)

* Update example configuration (#2013)

* Add more metadata to awsecscontainer receiver (#2011)

* add more metadata to awsecscontainer receiver

* use the image.tag instead of image.version for the key value

* Fix readme and add test to validate example config (#2000)

* Prometheus federation example (#2007)

* Add example showing how to use the Prometheus federation endpoint with prometheus_simple

* add copyright header to the file

* [exporter/datadog]: ensure that version tag is used for stats aggregations, add tests for computing apm stats (#2010)

* [AzureMonitorExporter] Favor RPC over HTTP spans (#378) (#2006)

Some instrumentation libraries are sending an RPC server span with both RPC and HTTP semantic attributes present (dotnet). In these cases we should favor the RPC attributes when figuring the  Span type.

* Adding ai.operation.parentid override

* Add composite sampling policy in tail sampler

* Fix lb exporter issues when DNS resolution fails during startup

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Cheng <jcheng@signalfx.com>
Co-authored-by: Eric Mustin <mustin.eric@gmail.com>
Co-authored-by: Albert Vaca Cintora <albert.vaca@datadoghq.com>
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
Co-authored-by: John <59711343+JohnWu20@users.noreply.github.com>
Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com>
Co-authored-by: Antoine Toulme <atoulme@users.noreply.github.com>
Co-authored-by: Pranav Pandit <pranavp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants