Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] lokiexporter update to use use generated status #21083

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Apr 20, 2023

Description:
Updates lokiexporter to use new generated status header. There are no warnings to list.

Link to tracking Issue: #19172

@mar4uk mar4uk requested review from a team, jpkrohling and kovrus as code owners April 20, 2023 08:26
@github-actions github-actions bot added the exporter/loki Loki Exporter label Apr 20, 2023
@@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:generate mdatagen metadata.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the code to use metadata.Stability in this file, to remove the possibility of having different levels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you!

@mar4uk mar4uk requested a review from codeboten April 20, 2023 09:53
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Apr 20, 2023
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to pick up the changes to skip a problematic unit test

@mar4uk mar4uk force-pushed the lokiexporter-generated-header branch from e297fac to 1eb0004 Compare April 21, 2023 09:10
@codeboten codeboten merged commit 106a221 into open-telemetry:main Apr 24, 2023
@github-actions github-actions bot added this to the next release milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/loki Loki Exporter ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants